Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lazy list in PopUp Menu #749

Open
francisconoriega opened this issue Jan 15, 2025 · 5 comments
Open

Add support for lazy list in PopUp Menu #749

francisconoriega opened this issue Jan 15, 2025 · 5 comments

Comments

@francisconoriega
Copy link
Contributor

When creating a Popup menu that has a lot of items (say listing all files in a directory), we get very degraded performance with the Current MenuScope api.

Could there be a way to change the internal impl to use LazyList Support to render each of the passive/selectable items?

@rock3r
Copy link
Collaborator

rock3r commented Jan 15, 2025

You should be able to use a PopupContainer (which looks like the "container" for a menu) plus whatever you want inside it. We do it for example on the new ListComboBox. Does that not work for you?

(Sorry, fat fingered the close button)

@rock3r rock3r closed this as completed Jan 15, 2025
@rock3r rock3r reopened this Jan 15, 2025
@francisconoriega
Copy link
Contributor Author

ah, I wasn't aware of that... let me try and I'll report!

@francisconoriega
Copy link
Contributor Author

francisconoriega commented Jan 15, 2025

Oh, I don't even see it so I think I might need to update to the newest version, we are currently on 0.25.0

@rock3r
Copy link
Collaborator

rock3r commented Jan 16, 2025

You definitely need to upgrade :)

@rock3r
Copy link
Collaborator

rock3r commented Jan 17, 2025

@francisconoriega let us know if PopupContainer works for you or not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants