Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown models don't have equals/hashcode implementation #416

Closed
rock3r opened this issue Jun 27, 2024 · 2 comments
Closed

Markdown models don't have equals/hashcode implementation #416

rock3r opened this issue Jun 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working markdown This issue impacts the Markdown rendering subsystem

Comments

@rock3r
Copy link
Collaborator

rock3r commented Jun 27, 2024

Since #331, equality and hashcode checks on ALL Markdown entities are meaningless, since all those models are value classes wrapping CommonMark models. CommonMark models do NOT implement equals and hashcode. This is potentially problematic for Compose usages, and many other cases.

We need to revert #331, since value classes do not support custom equals and hashcode implementations and we cannot rely on CommonMark models. We need true, content-based equals and hashcodes.

@rock3r rock3r added the bug Something isn't working label Jun 27, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Jul 11, 2024

@obask updates on this? I want to ship it in 0.20

@rock3r rock3r added the markdown This issue impacts the Markdown rendering subsystem label Jul 17, 2024
@rock3r
Copy link
Collaborator Author

rock3r commented Jul 19, 2024

Fixed in #458

@rock3r rock3r closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working markdown This issue impacts the Markdown rendering subsystem
Projects
None yet
Development

No branches or pull requests

2 participants