Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar in light theme have wrong color #259

Closed
fscarponi opened this issue Dec 1, 2023 · 1 comment · Fixed by #262
Closed

Scrollbar in light theme have wrong color #259

fscarponi opened this issue Dec 1, 2023 · 1 comment · Fixed by #262
Assignees
@fscarponi
Labels
bug Something isn't working consistency Our UI presentation is not consistent with IJ
Milestone
Milestone 11 — v0...

Comments

@fscarponi
Copy link
Collaborator

hovered colour is ok, but the default is not. In dark mode, it is correct!
image
image
@fscarponi fscarponi self-assigned this Dec 1, 2023
@rock3r rock3r added bug Something isn't working consistency Our UI presentation is not consistent with IJ labels Dec 1, 2023
@rock3r rock3r added this to the Milestone 11 — v0.11.0 milestone Dec 1, 2023
fscarponi added a commit that referenced this issue Dec 1, 2023
@fscarponi
Fix #259 Scrollbar color resolution from LAF in corner case
e740123
@fscarponi fscarponi mentioned this issue Dec 1, 2023
Merged
@fscarponi fscarponi linked a pull request Dec 1, 2023 that will close this issue
Fix scrollbar color when have 0f alpha #262
Merged
@fscarponi
Copy link
Collaborator Author

fixed with a workaround cause in the IDE can happen that the key in the LAF exists, but the color is not set or with the alpha channel set on 0f; in this case we fallback on Unspecified

rock3r pushed a commit that referenced this issue Dec 1, 2023
@fscarponi
Fix scrollbar color when have 0f alpha (#262)
cafd9e5 
* Fix Scrollbar color value handling in IntUiBridge.kt

* Fix #259 Scrollbar color resolution from LAF in corner case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fscarponi fscarponi

Labels
bug Something isn't working consistency Our UI presentation is not consistent with IJ
Projects
None yet
Milestone
Milestone 11 — v0.11.0
Development

Successfully merging a pull request may close this issue.

Fix scrollbar color when have 0f alpha JetBrains/jewel
2 participants
@rock3r @fscarponi