-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SelectableLazyColumn perf/code review #242
Comments
Also, there is a usecase that should be taken into account:
Now events handling is incapsulated in SelectableLazyColumn, so supporting this scenario is quite difficult |
Related: #470 |
The
SelectableLazyColumn
is a foundational component that will be used everywhere. As such, we need to make it work as well as it possibly can. This issue is to track the need to do a thorough code and perf review of the component, fixing any issues we find.Known concerns
allKeys: List<Key>
andkeyToIndex: Map<Int, Key>
shouldn't exist at all, since the API related to it causes O(n) selection change operations, where they should be O(1)The text was updated successfully, but these errors were encountered: