Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input field error states not consistent with spec #185

Closed
2 tasks done
c5inco opened this issue Oct 17, 2023 · 2 comments · Fixed by #187
Closed
2 tasks done

Input field error states not consistent with spec #185

c5inco opened this issue Oct 17, 2023 · 2 comments · Fixed by #187
Assignees
@fscarponi
Labels
bug Something isn't working

Comments

@c5inco
Copy link
Collaborator

c5inco commented Oct 17, 2023 •
edited by fscarponi
Loading

  • Unfocused state for error and warning has extra grey inner border
  • Focused state for error/warning doesn't show red border over blue

Spec: https://www.figma.com/community/file/1227732692272811382/int-ui-kit
@c5inco c5inco added the bug Something isn't working label Oct 17, 2023
@devkanro
Copy link
Collaborator

There are many inconsistent issue with spec, exactly the focus holo.

@fscarponi
Copy link
Collaborator

I'm going to fix this behavior for Dropdowns and InputFields where this issue is so evident

@fscarponi fscarponi linked a pull request Oct 17, 2023 that will close this issue
Improve UI control outlines management #187
Merged
@fscarponi fscarponi self-assigned this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fscarponi fscarponi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve UI control outlines management JetBrains/jewel
3 participants
@c5inco @devkanro @fscarponi