From fdf078a49c89c6bdd85ad62b8baf887acb13c594 Mon Sep 17 00:00:00 2001 From: Sebastiano Poggi Date: Mon, 9 Oct 2023 10:23:02 +0200 Subject: [PATCH 1/4] Fix SelectableLazyColumn not recomposing Fixes #160 by removing the remember call. Look at the issue for details. --- .../jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt b/core/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt index 1bc0aba2c..44e582d8e 100644 --- a/core/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt +++ b/core/src/main/kotlin/org/jetbrains/jewel/foundation/lazy/SelectableLazyColumn.kt @@ -48,9 +48,8 @@ fun SelectableLazyColumn( interactionSource: MutableInteractionSource = remember { MutableInteractionSource() }, content: SelectableLazyListScope.() -> Unit, ) { - val container = remember(content) { - SelectableLazyListScopeContainer().apply(content) - } + val container = SelectableLazyListScopeContainer() + .apply(content) val keys = remember(container) { container.getKeys() From c518465344e4dc23d0ddfdb89b000fcaa284cbd8 Mon Sep 17 00:00:00 2001 From: Sebastiano Poggi Date: Mon, 9 Oct 2023 10:39:43 +0200 Subject: [PATCH 2/4] Update README.md --- README.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 66bbf1061..c1055f341 100644 --- a/README.md +++ b/README.md @@ -9,10 +9,11 @@ desktop-optimized theme and set of components. > [!WARNING] > -> This project is in very early development and is probably not ready to be used in production projects. You _can_, but -> you should expect APIs to change fairly often, things to move around and/or break, and all that jazz. +> This project is in active development, and caution is advised when considering it for production uses. You _can_, +> but you should expect APIs to change often, things to move around and/or break, and all that jazz. Binary +> compatibility is not currently guaranteed across releases, but it is an eventual aim for 1.0, if it is possible. > -> Use at your risk! +> Use at your own risk! (but have fun if you do!) Jewel provides stand-alone implementations of the IntelliJ Platform themes that can be used in any Compose for Desktop application, and a Swing LaF Bridge that only works in the IntelliJ Platform (i.e., used to create IDE plugins), but From 6b3a3d6a3a4125ecac722edc13a083d9cd5aceaf Mon Sep 17 00:00:00 2001 From: Sebastiano Poggi Date: Mon, 9 Oct 2023 10:59:44 +0200 Subject: [PATCH 3/4] Update README.md --- README.md | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index c1055f341..64cb06248 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,5 @@ -[![JetBrains incubator](https://camo.githubusercontent.com/be6f8b50b2400e8b0dc74e58dd9a68803fe6698f5f30d843a7504888879f8392/68747470733a2f2f6a622e67672f6261646765732f696e63756261746f722d706c61737469632e737667)](https://github.com/JetBrains#jetbrains-on-github) [![CI checks](https://github.com/JetBrains/jewel/actions/workflows/build.yml/badge.svg?branch=main)](https://github.com/JetBrains/jewel/actions/workflows/build.yml) +[![JetBrains incubator](https://img.shields.io/badge/JetBrains-incubator-yellow)](https://github.com/JetBrains#jetbrains-on-github) [![CI checks](https://img.shields.io/github/actions/workflow/status/JetBrains/jewel/build.yml?logo=github)](https://github.com/JetBrains/jewel/actions/workflows/build.yml) [![Licensed under Apache 2.0](https://img.shields.io/github/license/JetBrains/jewel)](https://github.com/JetBrains/jewel/blob/main/LICENSE) [![Latest release](https://img.shields.io/github/v/release/JetBrains/jewel?include_prereleases&label=Latest%20Release&logo=github)](https://github.com/JetBrains/jewel/releases/latest) + # Jewel: a Compose for Desktop theme @@ -91,3 +92,22 @@ you, but if you want to also enable it in other scenarios and in standalone appl You can find help on the [`#jewel`](https://app.slack.com/client/T09229ZC6/C05T8U2C31T) channel on the Kotlin Slack. If you don't already have access to the Kotlin Slack, you can request it [here](https://surveys.jetbrains.com/s3/kotlin-slack-sign-up). + +## License +Jewel is licensed under the [Apache 2.0 license](https://github.com/JetBrains/jewel/blob/main/LICENSE). + +``` + Copyright 2022–3 JetBrains s.r.o. + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +``` From 9589ee77edb5a330b87930f6107969b2aee35d7e Mon Sep 17 00:00:00 2001 From: Sebastiano Poggi Date: Mon, 9 Oct 2023 11:00:01 +0200 Subject: [PATCH 4/4] Update LICENSE --- LICENSE | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index d2876367b..b0ed66dd3 100644 --- a/LICENSE +++ b/LICENSE @@ -186,7 +186,7 @@ same "printed page" as the copyright notice for easier identification within third-party archives. - Copyright 2022 JetBrains + Copyright 2022–3 JetBrains s.r.o. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.