diff --git a/.changeset/late-ravens-smoke.md b/.changeset/late-ravens-smoke.md deleted file mode 100644 index 34c2c7931..000000000 --- a/.changeset/late-ravens-smoke.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@qwik-ui/headless': patch ---- - -fix: select validates correctly with modular forms diff --git a/.changeset/twenty-spoons-fail.md b/.changeset/twenty-spoons-fail.md new file mode 100644 index 000000000..de92b2cae --- /dev/null +++ b/.changeset/twenty-spoons-fail.md @@ -0,0 +1,5 @@ +--- +'@qwik-ui/headless': patch +--- + +Chromium 109-113 did not properly support the popover but reported that they did. This led to the polyfill not activating which caused our E2E tests to break. We are dropping down to Chromium 108 to validate the polyfill as users of Chrome would see it before the popover API was supported. diff --git a/apps/website/src/routes/docs/headless/select/examples/description.tsx b/apps/website/src/routes/docs/headless/select/examples/description.tsx new file mode 100644 index 000000000..4f4061c9c --- /dev/null +++ b/apps/website/src/routes/docs/headless/select/examples/description.tsx @@ -0,0 +1,33 @@ +import { component$, useStyles$ } from '@builder.io/qwik'; +import { Select } from '@qwik-ui/headless'; + +export default component$(() => { + useStyles$(styles); + const users = ['Tim', 'Ryan', 'Jim', 'Jessie', 'Abby']; + + return ( + + Logged in users + + + + Select a user to see their profile + + + {users.map((user) => ( + + {user} + + + + + ))} + + + + ); +}); + +// internal +import styles from '../snippets/select.css?inline'; +import { LuCheck } from '@qwikest/icons/lucide'; diff --git a/apps/website/src/routes/docs/headless/select/examples/validation.tsx b/apps/website/src/routes/docs/headless/select/examples/validation.tsx index 865c4b57f..fd51df1b0 100644 --- a/apps/website/src/routes/docs/headless/select/examples/validation.tsx +++ b/apps/website/src/routes/docs/headless/select/examples/validation.tsx @@ -34,7 +34,11 @@ export default component$(() => { - {field.error &&
{field.error}
} + {field.error && ( + + {field.error} + + )} {users.map((user) => ( diff --git a/apps/website/src/routes/docs/headless/select/index.mdx b/apps/website/src/routes/docs/headless/select/index.mdx index 212ae3b6e..031b58968 100644 --- a/apps/website/src/routes/docs/headless/select/index.mdx +++ b/apps/website/src/routes/docs/headless/select/index.mdx @@ -175,7 +175,15 @@ The native select element is created when a form name has been given to `