Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you please rebase for chromium 130.0.6723.91 #130

Open
MastaG opened this issue Nov 7, 2024 · 2 comments
Open

Could you please rebase for chromium 130.0.6723.91 #130

MastaG opened this issue Nov 7, 2024 · 2 comments

Comments

@MastaG
Copy link

MastaG commented Nov 7, 2024

The patches do apply with fuzz, but compilation seems to fail.
If you have some spare time, could you please create a patch-set for chromium 130.0.6723.91.

@MastaG
Copy link
Author

MastaG commented Nov 7, 2024

This is the error I'm getting:

../../media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc:446:20: error: non-constant-expression cannot be narrowed from type '__suseconds64_t' (aka 'long long') to 'long' in initializer list [-Wc++11-narrowing]
  446 |         .tv_nsec = timeval.tv_usec * 1000,
      |                    ^~~~~~~~~~~~~~~~~~~~~~
../../media/gpu/v4l2/legacy/v4l2_video_decoder_backend_stateful.cc:446:20: note: insert an explicit cast to silence this issue
  446 |         .tv_nsec = timeval.tv_usec * 1000,
      |                    ^~~~~~~~~~~~~~~~~~~~~~
      |                    static_cast<long>(    )
1 error generated.

@JeffyCN
Copy link
Owner

JeffyCN commented Nov 8, 2024

maybe try to add 'static_cast' as it suggested:

-        .tv_nsec = timeval.tv_usec * 1000,
+        .tv_nsec = static_cast<long>(timeval.tv_usec * 1000),

guessing you are compiling for arm32, maybe these kind of errors would be better to be fixed in the official meta-browser?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants