Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share link support #4

Closed
2 tasks
JeffreyCA opened this issue Nov 30, 2023 · 2 comments
Closed
2 tasks

Share link support #4

JeffreyCA opened this issue Nov 30, 2023 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@JeffreyCA
Copy link
Owner

JeffreyCA commented Nov 30, 2023

From EthanArbuckle#36:

Recently Reddit started implementing a new format for share URLs on their mobile apps. This is not supported by Apollo.

how it breaks Apollo When a user clicks on one of these links, instead of being pushed to the post or comment in question, a WebView opens. This page is often broken if the share link is to another comment, or NSFW post.

Example:

  1. shortlinks https://redd.it/1641krf redirects to https://www.reddit.com/r/ModSupport/comments/1641krf/reddit_broke_the_report_forms_by_now_using_a/
  2. mobile sharelinks https://reddit.com/r/ModSupport/s/9aRRC2rZpd redirects to https://www.reddit.com/r/ModSupport/comments/1641krf/reddit_broke_the_report_forms_by_now_using_a/?share_id=HXzTX3cWsSnrFxIy1IsDg (includes trackable share_id)

Current bugs:

  • Share links in private messages still open in the in-app browser
  • Long-tapping share links still pop open a browser page
@JeffreyCA JeffreyCA added the bug Something isn't working label Nov 30, 2023
@JeffreyCA
Copy link
Owner Author

@losh11, just added support for share links in v1.0.4! Took quite a bit of trial and error and I might've over-engineered some parts of it but it functions nicely for the most part.

There are currently a few limitations:

  • Share links in private messages still open in the in-app browser
  • Long-tapping share links still pop open a browser page

Please let me know if you run into any issues with it.

@JeffreyCA JeffreyCA added the help wanted Extra attention is needed label Nov 30, 2023
@JeffreyCA
Copy link
Owner Author

Closing for now, minor bugs remain:

  • Share links in private messages still open in the in-app browser
  • Long-tapping share links still pop open a browser page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant