Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: centralize creator banks and set unique IDs #306

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Oct 29, 2024

No description provided.

@c-dilks c-dilks marked this pull request as ready for review December 3, 2024 19:56
@c-dilks c-dilks requested a review from rtysonCLAS12 as a code owner December 3, 2024 19:56
Copy link
Contributor

@rtysonCLAS12 rtysonCLAS12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will make creating new banks a lot easier.

My only question is why bankgen.py doesn't map 'S' to the C++ short type (line 27). Guessing there's a good reason, just curious.

@c-dilks
Copy link
Member Author

c-dilks commented Dec 5, 2024

Looks good, will make creating new banks a lot easier.

My only question is why bankgen.py doesn't map 'S' to the C++ short type (line 27). Guessing there's a good reason, just curious.

Good point. We should set the types according to hipo::bank, perhaps with decltype, such as

decltype(std::declval<hipo::bank>().getInt(0, 0))

As an aside, here are the types (note there is some casting done internally):

type hipo::structure::get___At(...) hipo::bank::get___(...)
Byte int8_t int
Short int16_t int
Int int int
Float float float
Double double double
Long long int64_t

I opened an issue in hipo for this: gavalian/hipo#71

@c-dilks c-dilks linked an issue Dec 12, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Unsorted
Development

Successfully merging this pull request may close these issues.

Algorithm::CreateBank: generalize groupid and itemid
2 participants