-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: centralize creator banks and set unique IDs #306
base: main
Are you sure you want to change the base?
Conversation
f7af0ed
to
f251c50
Compare
f251c50
to
a7a36a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will make creating new banks a lot easier.
My only question is why bankgen.py doesn't map 'S' to the C++ short type (line 27). Guessing there's a good reason, just curious.
Good point. We should set the types according to decltype(std::declval<hipo::bank>().getInt(0, 0)) As an aside, here are the types (note there is some casting done internally):
I opened an issue in |
No description provided.