From 133fdac876b8cb1de5e90eeaec38c9327be68ee3 Mon Sep 17 00:00:00 2001 From: Christopher Dilks Date: Fri, 12 Jan 2024 20:17:39 -0500 Subject: [PATCH] fix: can't build `fmt` static and shared libs simultaneously --- .github/workflows/ci.yml | 2 +- doc/setup.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 465dfb08..a8ddda3d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -58,7 +58,7 @@ jobs: ref: ${{ env.fmt_version }} - name: build run: | - cmake -S . -B build -DCMAKE_INSTALL_PREFIX=fmt -DBUILD_SHARED_LIBS=TRUE -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE + cmake -S . -B build -DCMAKE_INSTALL_PREFIX=fmt -DBUILD_SHARED_LIBS=TRUE cmake --build build -j2 cmake --install build - run: brew install tree diff --git a/doc/setup.md b/doc/setup.md index 87e5115b..f07ec0be 100644 --- a/doc/setup.md +++ b/doc/setup.md @@ -27,7 +27,7 @@ python -m pip install meson ninja ### :large_orange_diamond: `fmt`: C++ output formatting library - likely available in your package manager, likely as `fmt` or `libfmt` -- if you compile it yourself, include the `cmake` options `-DBUILD_SHARED_LIBS=TRUE` and `-DCMAKE_POSITION_INDEPENDENT_CODE=TRUE` +- if you compile it yourself, include the `cmake` option `-DBUILD_SHARED_LIBS=TRUE` - example `cmake` commands: ```bash cmake -S /path/to/fmt_source_code -B build-fmt -DCMAKE_INSTALL_PREFIX=/path/to/fmt_installation -DBUILD_SHARED_LIBS=TRUE -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE