Incorrect Trigger type CFCAL

[aaust]

For the 2022-08 PrimEx data set, the current halld_recon master prints many error messages of this type:

Incorrect Trigger type CFCAL

The trigger emulation does not seem to include this type in

halld_recon/src/libraries/TRIGGER/DL1MCTrigger_factory.cc

Line 891 in 1d98aa5

cout << " Incorrect Trigger type " << triggerTypes[jj][1] << endl;

[somovalex]

Yes, the trigger emulation has not yet been included for this trigger type. We can skip it at the moment.

…

________________________________ From: Alexander Austregesilo ***@***.***> Sent: Monday, March 25, 2024 4:40 PM To: JeffersonLab/halld_recon ***@***.***> Cc: Subscribed ***@***.***> Subject: [EXTERNAL] [JeffersonLab/halld_recon] Incorrect Trigger type CFCAL (Issue #791) For the 2022-08 PrimEx data set, the current halld_recon master prints many error messages of this type: Incorrect Trigger type CFCAL The trigger emulation does not seem to include this type in https://github.com/JeffersonLab/halld_recon/blob/1d98aa5c06198d83129c32a2ab27f23e6feb4857/src/libraries/TRIGGER/DL1MCTrigger_factory.cc#L891<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_blob_1d98aa5c06198d83129c32a2ab27f23e6feb4857_src_libraries_TRIGGER_DL1MCTrigger-5Ffactory.cc-23L891&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=6PVTX64ly26ADgUk55NNczAr007m6Ige_PEIEp55L_kVyOmn0YMZVA6vx4GWGOnP&s=q4sc-L_6-MVkqxKk7BQwpoetpnA-cpOgSOASyvUqRdo&e=> — Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_issues_791&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=6PVTX64ly26ADgUk55NNczAr007m6Ige_PEIEp55L_kVyOmn0YMZVA6vx4GWGOnP&s=g34AV16bIr6I4Dw9_7AoI_On5vbx7005VqKG5MACe5A&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD4KOG7QX6DM5G6CCXYFIMTY2CDTJAVCNFSM6AAAAABFHWM35CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDMNRWGY2DGMI&d=DwMCaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=6PVTX64ly26ADgUk55NNczAr007m6Ige_PEIEp55L_kVyOmn0YMZVA6vx4GWGOnP&s=46JZmsIlIdAzpRJzo_0rAQhtYdrf_YdpVTWZnEXF5Uc&e=>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[aaust]

@somovalex Should this be included before we start REST production?

[somovalex]

We can skip it for this launch

…

________________________________ From: Alexander Austregesilo ***@***.***> Sent: Tuesday, March 26, 2024 9:42 AM To: JeffersonLab/halld_recon ***@***.***> Cc: Alexander Somov ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [JeffersonLab/halld_recon] Incorrect Trigger type CFCAL (Issue #791) @somovalex<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_somovalex&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=mvtht_k0kdBAB4l2KDbRFot2gY-KZIqxuphZBA6J1L5OI-Ic_owQKEdbpqbEjRZT&s=6zO_OmhFa2eWF-ItsXtUHBP8eKQNpEVib8mABYCOeZQ&e=> Should this be included before we start REST production? — Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_issues_791-23issuecomment-2D2020465013&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=mvtht_k0kdBAB4l2KDbRFot2gY-KZIqxuphZBA6J1L5OI-Ic_owQKEdbpqbEjRZT&s=ZRJs86CwM3T2vHeFJ8iD3UUEwEkfB07DtJ209tD5mDI&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD4KOGYD4MZ7JUHOV6TBUNDY2F3NHAVCNFSM6AAAAABFHWM35CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRQGQ3DKMBRGM&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=mvtht_k0kdBAB4l2KDbRFot2gY-KZIqxuphZBA6J1L5OI-Ic_owQKEdbpqbEjRZT&s=uwapZGryLI5JKrfw3GgPsfG1u7nL1lUvqX1b1PoyQSE&e=>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[sdobbs]

for the record, this code is called in the data reconstruction to estimate the trigger calorimeter energy sums, and the trigger bit info is ignored. So maybe the short term fix is to limit the number of times this error message is printed out.

Of course, simulation of this trigger type is needed for acceptance corrections.

[somovalex]

Yes, this would be the temporary solution (before I finish up with the final implementation)

…

________________________________ From: Sean Dobbs ***@***.***> Sent: Thursday, March 28, 2024 5:34 PM To: JeffersonLab/halld_recon ***@***.***> Cc: Alexander Somov ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [JeffersonLab/halld_recon] Incorrect Trigger type CFCAL (Issue #791) for the record, this code is called in the data reconstruction to estimate the trigger calorimeter energy sums, and the trigger bit info is ignored. So maybe the short term fix is to limit the number of times this error message is printed out. Of course, simulation of this trigger type is needed for acceptance corrections. — Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_JeffersonLab_halld-5Frecon_issues_791-23issuecomment-2D2026170169&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=96R7jM-DgCf78QQy78e_DaCEMiPtUnZcw8tuwX9kmvvAlTMrMVgEMUFF9gWRMFcB&s=QhcUAxTOnlcxyxPP5xhfO46999bazUIpxNVtWb54XqU&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AD4KOG2LCLKTZVFWICT3U6TY2SEHLAVCNFSM6AAAAABFHWM35CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGE3TAMJWHE&d=DwMFaQ&c=CJqEzB1piLOyyvZjb8YUQw&r=UEJkvUcBvE4mBa6l1pQs5Q&m=96R7jM-DgCf78QQy78e_DaCEMiPtUnZcw8tuwX9kmvvAlTMrMVgEMUFF9gWRMFcB&s=Kec7E-TJp6kMi8ZcGJ-32VHJNKenFiga1_SnGW8bthc&e=>. You are receiving this because you were mentioned.Message ID: ***@***.***>