Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEWGI Cologne: remove the terminate(pid) from process class interface #28

Open
JeffGarland opened this issue Jul 21, 2019 · 3 comments
Open

Comments

@JeffGarland
Copy link
Owner

Reason is mostly simplification, but also some mild concerns about security issues that might arise.

@klemens-morgenstern
Copy link
Contributor

The terminate in general or which exactly?

@JeffGarland
Copy link
Owner Author

So we discussed again in Belfast - I munged this originally. The actual request here is to remove the 'pid' constructor so that we won't have the ability to attach and then call terminate.

I think its a fair trade-off unless we have a really strong set of use cases. We won't have the ability to manage arbitrary processes, but only the ones we create.

@klemens-morgenstern
Copy link
Contributor

The security issue concerns the OS right system, normally you can only terminate child processes and their children.

I only have minor use cases, but I don't really get what the risk is. So the main application is either pass PIDs between processes or managing a process created by another library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants