Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative options in text for start_dir and process_io #20

Open
JeffGarland opened this issue Jun 16, 2019 · 4 comments
Open

Alternative options in text for start_dir and process_io #20

JeffGarland opened this issue Jun 16, 2019 · 4 comments

Comments

@JeffGarland
Copy link
Owner

// Provides an initializers for the standard io. Alternative: nested as std::process::io
class process_io;

// Provides a way to set the starting directory of the new process. Alternative: nested as std::process::start_dir

What you have looks good to me - going to drop the alternative text.

@JeffGarland
Copy link
Owner Author

And on the start_dir did we discuss why we aren't just using filesystem::path?

@JeffGarland
Copy link
Owner Author

bc that's whats here:

requires ConvertibleTo<iter_value_t, string>
explicit process(const filesystem::path& exe, const R& args, Inits&&... inits);

@klemens-morgenstern
Copy link
Contributor

start_dir should take an fs::path, but should be a different type as to not be confused woth the executable.

@JeffGarland
Copy link
Owner Author

ok. So this has been excised from the proposal currently. After I did that I think I gained more understanding of the initializer. But inclined to leave it alone for now anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants