Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 support #16

Open
insolite opened this issue Oct 8, 2017 · 9 comments
Open

React 16 support #16

insolite opened this issue Oct 8, 2017 · 9 comments

Comments

@insolite
Copy link

insolite commented Oct 8, 2017

As mentioned in React 15.5 release notes, React.createClass (MDEditor.js#L13) and React.PropTypes (MDEditor.js#L16-L19) are now deprecated.
Are there any plans for making further releases with such replacements to make editor support React 16?

@daanishnasir
Copy link

Yeah total bummer; doesn't seem to work anymore.

@JodieHag
Copy link

No, no work in React 16! :(

@ttbarnes
Copy link

+1

@hungrypipo
Copy link

hungrypipo commented Feb 17, 2018

Wait, why is this hard to fix? Isn't is just refactor out React.createClass and React.PropTypes

@insolite
Copy link
Author

As far as I remember there are something else to fix. I've tried to rewrite only createClass/PropTypes and faced with a bunch of another issues which I had no time to deal with. So I just posted generic issue with some proofs here.

@Venryx
Copy link

Venryx commented Apr 12, 2018

Seeing as this one's not being maintained, the following might be a better option: https://github.com/andrerpena/react-mde

EDIT: Nevermind, I looked at the other one and get the idea that the developer is overengineering; it doesn't seem to have much additional functionality, yet uses like 10 times as many files to do it. (and ~3 times as many lines) Probably better just to patch up this one.

@brandonrobertz
Copy link

@Venryx the other one you mentioned (https://github.com/andrerpena/react-mde) uses Draft.js as the editor front end, so it has a lot more functionality than this project (revisions/history, pasting of files, images, links, removal by block, etc). So it's not just wasted extra files -- Draft.js is somewhat opinionated, but does a lot of heavy lifting. (Just dropping this as a note for anyone else encountering this project's issue and thinking of jumping ship.)

@johnsonsamuel
Copy link

Any update on this ? :(

@brandonrobertz
Copy link

@johnsonsamuel I ended up working around this by using https://github.com/sstur/react-rte as an editor and https://github.com/rexxars/react-markdown as the renderer. They're both React first and have XSS safety unlike this module and https://github.com/andrerpena/react-mde

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants