Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine call.Param list actions #138

Open
Jaymon opened this issue Apr 18, 2024 · 1 comment
Open

Combine call.Param list actions #138

Jaymon opened this issue Apr 18, 2024 · 1 comment

Comments

@Jaymon
Copy link
Owner

Jaymon commented Apr 18, 2024

Right now there are three different list actions:

  • "store_list" - set to have a value like 1,2,3 be blown up to ['1', '2', '3']
  • "append" - if multiple param values should be turned into an array (eg, foo=1&foo=2 would become foo=[1, 2])
  • "append_list" - it's store_list + append, so foo=1&foo=2,3 would become foo=[1, 2, 3]

I'm sure I had a reason to have all these be separate at some point in the past but the reasoning has been completely lost to time and I think append_list should be the only way.

So basically, remove append_list and append and take the functionality of the current append_list and rename it store_list.

@Jaymon
Copy link
Owner Author

Jaymon commented Sep 13, 2024

argparse action has append and extend, I think I can merge store_list and append_list into extend and keep action as is. I think that would mostly be consistent with how argparse does it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant