From c9911a9b537c76633c54f6d9f0d49318756cc58f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?JasonXuDeveloper=20-=20=E5=82=91?=
 <jasonxudeveloper@gmail.com>
Date: Mon, 11 Nov 2024 17:09:13 +1100
Subject: [PATCH] release v2.1.9

## Nino.Serialization v2.1.9
- [Optimization] Faster deserialization
---
 src/Nino.Core/Reader.cs                       | 32 +++++++++----------
 .../EmbedTypeDeserializerGenerator.cs         | 10 +++---
 2 files changed, 22 insertions(+), 20 deletions(-)

diff --git a/src/Nino.Core/Reader.cs b/src/Nino.Core/Reader.cs
index 9bb7812..030b3cf 100644
--- a/src/Nino.Core/Reader.cs
+++ b/src/Nino.Core/Reader.cs
@@ -17,7 +17,7 @@ public Reader(Span<byte> buffer)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public void Read<T>(out T value) where T : unmanaged
         {
-            value = Unsafe.ReadUnaligned<T>(ref MemoryMarshal.GetReference(_data));
+            value = Unsafe.ReadUnaligned<T>(ref _data[0]);
             _data = _data.Slice(Unsafe.SizeOf<T>());
         }
 
@@ -52,13 +52,12 @@ public void Read<T>(out T[] ret) where T : unmanaged
                     Read(out int length);
                     GetBytes(length * Unsafe.SizeOf<T>(), out var bytes);
 #if NET5_0_OR_GREATER
-                    ret = bytes.Length > 2048 ? GC.AllocateUninitializedArray<T>(length) : new T[length];
-                    Span<T> span = ret;
-                    Span<byte> byteSpan = MemoryMarshal.Cast<T, byte>(span);
-                    Unsafe.CopyBlockUnaligned(ref byteSpan[0], ref bytes[0], (uint)bytes.Length);
+                    ret = bytes.Length <= 2048 ? new T[length] : GC.AllocateUninitializedArray<T>(length);
 #else
-                    ret = MemoryMarshal.Cast<byte, T>(bytes).ToArray();
+                    ret = new T[length];
 #endif
+                    ref byte first = ref Unsafe.As<T, byte>(ref ret[0]);
+                    Unsafe.CopyBlockUnaligned(ref first, ref bytes[0], (uint)bytes.Length);
                     return;
                 default:
                     throw new InvalidOperationException($"Invalid type id {typeId}");
@@ -101,19 +100,17 @@ public void Read<T>(out List<T> ret) where T : unmanaged
                 case TypeCollector.CollectionTypeId:
                     Read(out int length);
                     GetBytes(length * Unsafe.SizeOf<T>(), out var bytes);
-                    ret = new List<T>(length);
-#if NET5_0_OR_GREATER
+                    ret = new List<T>();
                     ref var lst = ref Unsafe.As<List<T>, TypeCollector.ListView<T>>(ref ret);
                     lst._size = length;
-                    Span<byte> byteSpan = MemoryMarshal.Cast<T, byte>(lst._items);
-                    Unsafe.CopyBlockUnaligned(ref byteSpan[0], ref bytes[0], (uint)bytes.Length);
+#if NET5_0_OR_GREATER
+                    var arr = bytes.Length <= 2048 ? new T[length] : GC.AllocateUninitializedArray<T>(length);
 #else
-                    ReadOnlySpan<T> span = MemoryMarshal.Cast<byte, T>(bytes);
-                    for (int i = 0; i < length; i++)
-                    {
-                        ret.Add(span[i]);
-                    }
+                    var arr = new T[length];
 #endif
+                    ref byte first = ref Unsafe.As<T, byte>(ref arr[0]);
+                    Unsafe.CopyBlockUnaligned(ref first, ref bytes[0], (uint)bytes.Length);
+                    lst._items = arr;
 
                     return;
                 default:
@@ -207,7 +204,10 @@ public void Read(out string ret)
                     Read(out int length);
                     GetBytes(length * sizeof(char), out var bytes);
 #if NET5_0_OR_GREATER
-                    ret = new string(MemoryMarshal.Cast<byte, char>(bytes));
+                    ret = new string(
+                        MemoryMarshal.CreateReadOnlySpan(
+                            ref Unsafe.As<byte, char>(ref bytes[0]),
+                            length));
 #else
                     ret = MemoryMarshal.Cast<byte, char>(bytes).ToString();
 #endif
diff --git a/src/Nino.Generator/EmbedTypeDeserializerGenerator.cs b/src/Nino.Generator/EmbedTypeDeserializerGenerator.cs
index 443e6f3..ce986a8 100644
--- a/src/Nino.Generator/EmbedTypeDeserializerGenerator.cs
+++ b/src/Nino.Generator/EmbedTypeDeserializerGenerator.cs
@@ -256,7 +256,7 @@ bool IsTypeParameter(ITypeSymbol typeSymbol)
             {
                 var elemType = ((IArrayTypeSymbol)type).ElementType.ToDisplayString();
                 if (addedElemType.Add(elemType))
-                    sb.AppendLine(GenerateArrayCollectionSerialization(
+                    sb.AppendLine(GenerateArraySerialization(
                         ((IArrayTypeSymbol)type).ElementType.GetDeserializePrefix(),
                         elemType, "        "));
                 sb.GenerateClassDeserializeMethods(typeFullName);
@@ -268,7 +268,7 @@ bool IsTypeParameter(ITypeSymbol typeSymbol)
             {
                 var elemType = s.TypeArguments[0].ToDisplayString();
                 if (addedElemType.Add(elemType))
-                    sb.AppendLine(GenerateArrayCollectionSerialization(s.TypeArguments[0].GetDeserializePrefix(),
+                    sb.AppendLine(GenerateArraySerialization(s.TypeArguments[0].GetDeserializePrefix(),
                         elemType,
                         "        "));
                 if (type.TypeKind != TypeKind.Interface)
@@ -323,7 +323,7 @@ public static partial class Deserializer
         context.AddSource("NinoDeserializerExtension.Ext.g.cs", code);
     }
 
-    private static string GenerateArrayCollectionSerialization(string prefix, string elemType, string indent)
+    private static string GenerateArraySerialization(string prefix, string elemType, string indent)
     {
         var creationDecl = elemType.EndsWith("[]")
             ? elemType.Insert(elemType.IndexOf("[]", StringComparison.Ordinal), "[length]")
@@ -342,9 +342,11 @@ public static void Deserialize(out {{elemType}}[] value, ref Reader reader)
                             case TypeCollector.CollectionTypeId:
                                 reader.Read(out int length);
                                 value = new {{creationDecl}};
+                                var span = value.AsSpan();
                                 for (int i = 0; i < length; i++)
                                 {
-                                    {{prefix}}(out value[i], ref reader);
+                                    {{prefix}}(out {{elemType}} val, ref reader);
+                                    span[i] = val;
                                 }
                                 break;
                             default: