Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom keyboard shortcuts #18

Open
Japh opened this issue Feb 5, 2013 · 2 comments
Open

Support for custom keyboard shortcuts #18

Japh opened this issue Feb 5, 2013 · 2 comments
Assignees
Milestone

Comments

@Japh
Copy link
Owner

Japh commented Feb 5, 2013

It's been requested that I make it possible to configure your own keyboard shortcut for WP Butler. While I like the idea of a ubiquitous shortcut, I also appreciate the need for customisation, so I will add this as a hook.

@ghost ghost assigned Japh Feb 5, 2013
@evansolomon
Copy link
Contributor

I made some updates to JS keyStroke this weekend that might be useful for this. One of them was to bind the keystroke events with jQuery namespaces, so they can be more easily unbound. Here are two relevant commits:

So you could unbind all keystrokes with something like $(document).off('JQkeyStroke') or just a specific keystroke like $(document).off('JQkeyStroke-67-ctrlKey') (all keystrokes are bound to $(document)).

@Japh
Copy link
Owner Author

Japh commented Feb 19, 2013

Fantastic! Thanks, Evan, I'll experiment with this for 2.1 and update js-keystroke as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants