-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the circular initialization dependency #4658 #4659
Fix the circular initialization dependency #4658 #4659
Conversation
|
cbc2161
to
1dd99ec
Compare
My first commit missed the Signed-Off-By and email configuration, so I fixed it locally and updated the commit message. But I don't know how to fix the EasyCLA issue. |
@ministat If you click on the "Details" link, does it give you an option to (re)sign the CLA? |
I just triggered a rerun of failed tests |
Does the CLA expire? I signed CLA in 2022.
|
Yes, it asked me to re-sign. I have signed again. |
ModifierType and TypeDefinitionCategory has circular initialization dependency, as a result, if we access ModifierType before TypeDefinitionCategory, it will cause java.lang.ExceptionInInitializerError problem. Signed-off-by: Hongjiang Zhang <[email protected]>
1dd99ec
to
17b7c84
Compare
The image is broken so I couldn't view it. I am guessing maybe we could try closing the issue and reopening again to trigger a rerun of EasyCLA. |
Hmm reopening doesn't help. Could you please try opening a dummy PR and see if it works in a new PR? Also C.C. @FlorianHockmann - is this something we can escalate to LFAI & Data? |
Sure, the docs link to this JIRA for support issues. I think only people from the Linux Foundation can inspect our signed CLAs. If we link this PR, then they should be able to check what's wrong here. |
Let me close this PR and create a new one. |
Recreate the PR to check whether can work around the EasyCLA issue. |
Fix the issue #4658:
ModifierType and TypeDefinitionCategory has circular initialization dependency, as a result, if we access ModifierType before TypeDefinitionCategory, it will cause java.lang.ExceptionInInitializerError problem.
A UT is included. No document change.
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: