Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the circular initialization dependency #4658 #4659

Closed

Conversation

ministat
Copy link
Contributor

Fix the issue #4658:

ModifierType and TypeDefinitionCategory has circular initialization dependency, as a result, if we access ModifierType before TypeDefinitionCategory, it will cause java.lang.ExceptionInInitializerError problem.

A UT is included. No document change.


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Copy link

linux-foundation-easycla bot commented Aug 26, 2024

CLA Missing ID CLA Not Signed

@ministat ministat force-pushed the hj_fix_enum_circular_dependency branch 2 times, most recently from cbc2161 to 1dd99ec Compare August 26, 2024 08:09
@ministat
Copy link
Contributor Author

ministat commented Aug 27, 2024

My first commit missed the Signed-Off-By and email configuration, so I fixed it locally and updated the commit message. But I don't know how to fix the EasyCLA issue.
In addition, the CI failed case is about Hbase backend which failed to be launched, so it is not related to my CI. I think it needs to be rerun after EasyCLA issue was resolved.

@li-boxuan
Copy link
Member

@ministat If you click on the "Details" link, does it give you an option to (re)sign the CLA?

image

@li-boxuan
Copy link
Member

I just triggered a rerun of failed tests

@ministat
Copy link
Contributor Author

ministat commented Aug 27, 2024 via email

@ministat
Copy link
Contributor Author

@ministat If you click on the "Details" link, does it give you an option to (re)sign the CLA?

image

Yes, it asked me to re-sign. I have signed again.

ModifierType and TypeDefinitionCategory has circular initialization dependency,
as a result, if we access ModifierType before TypeDefinitionCategory, it will
cause java.lang.ExceptionInInitializerError problem.

Signed-off-by: Hongjiang Zhang <[email protected]>
@ministat ministat force-pushed the hj_fix_enum_circular_dependency branch from 1dd99ec to 17b7c84 Compare August 28, 2024 00:31
@li-boxuan
Copy link
Member

@ministat If you click on the "Details" link, does it give you an option to (re)sign the CLA?
image

Yes, it asked me to re-sign. I have signed again.

The image is broken so I couldn't view it. I am guessing maybe we could try closing the issue and reopening again to trigger a rerun of EasyCLA.

@li-boxuan li-boxuan closed this Aug 29, 2024
@li-boxuan li-boxuan reopened this Aug 29, 2024
@li-boxuan
Copy link
Member

Hmm reopening doesn't help. Could you please try opening a dummy PR and see if it works in a new PR?

Also C.C. @FlorianHockmann - is this something we can escalate to LFAI & Data?

@FlorianHockmann
Copy link
Member

Sure, the docs link to this JIRA for support issues.

I think only people from the Linux Foundation can inspect our signed CLAs. If we link this PR, then they should be able to check what's wrong here.

@ministat
Copy link
Contributor Author

Let me close this PR and create a new one.

@ministat
Copy link
Contributor Author

Recreate the PR to check whether can work around the EasyCLA issue.

@ministat ministat closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants