Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TinkerPop version to 3.7.0 [cql-tests][tp-tests] #3914

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

li-boxuan
Copy link
Member

@li-boxuan li-boxuan commented Aug 12, 2023

This includes:

  1. Upgraded maven dependency version
  2. Fixed compilation errors caused by breaking changes
  3. Fixed maven dependency convergence errors
  4. Enabled one previously disabled test
  5. Updated upgrade doc

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Aug 12, 2023
This includes:
1. Upgraded maven dependency version
2. Fixed compilation errors caused by breaking changes
3. Fixed maven dependency convergence errors
4. Enabled one previously disabled test
4. Updated upgrade doc

Signed-off-by: Boxuan Li <[email protected]>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @li-boxuan !

@li-boxuan li-boxuan merged commit 20abdde into JanusGraph:master Aug 13, 2023
190 checks passed
@li-boxuan li-boxuan deleted the upgrade-tinkerpop-3.7.0 branch August 13, 2023 21:10
@@ -14,4 +14,4 @@

hosts: [localhost]
port: 8182
serializer: { className: org.apache.tinkerpop.gremlin.driver.ser.GraphBinaryMessageSerializerV1, config: { serializeResultToString: true }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed that I'm now getting a warning if I try to use this config file with our latest Docker images:

gremlin> :remote connect tinkerpop.server conf/remote.yaml session
Sep 13, 2023 2:23:59 PM org.yaml.snakeyaml.internal.Logger warn
WARNING: Failed to find field for org.apache.tinkerpop.gremlin.driver.Settings.serializers

Do you know what could be causing this, @li-boxuan?

It however continues to work afterwards. I haven't tested however whether the serializer config is actually used or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't notice this warning - thanks for bringing it up. I am guessing it's caused by some dependency upgrade in TinkerPop, maybe they bumped the snakeyaml dependency and broke backward compatibility.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// WARNING: Failed to find field for org.apache.tinkerpop.gremlin.driver.Settings.serializers

Shouldn't this be org.apache.tinkerpop.gremlin.server.Settings.serializers ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be org.apache.tinkerpop.gremlin.server.Settings.serializers ?

Yeah so the warning itself doesn't quite make sense. Somehow the code believes the driver should also have this serializers setting, and since the driver doesn't, snakeyaml logs a warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tinkerpop cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants