-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(jans-cedarling): update AuthZ interface to use tokens
for all JWTs sent as input
#10521
base: main
Are you sure you want to change the base?
Conversation
…l JWTs sent as input Signed-off-by: rmarinn <[email protected]>
Signed-off-by: rmarinn <[email protected]>
Signed-off-by: rmarinn <[email protected]>
…oken Signed-off-by: rmarinn <[email protected]>
- fix the broken tests due to removing the creation of workload entity using the userinfo token Signed-off-by: rmarinn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me. Does python bindings support loading Request
from JSON?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good to me but we need to fix the pyproject.toml file because builds are failing right now. We need to decide on whether we want to statically define version like so:
[project]
version = "0.0.0"
or have the wheel dynamically retrieve version from the cedarling crate:
dynamic = ["version"]
Both cannot coexist, which is why builds are failing. @moabu could you weigh in on which one we want for releases?
Signed-off-by: rmarinn <[email protected]>
Prepare
Description
Target issue
target issue: #10437
closes #10437
Implementation Details
moves the tokens in the AuthZ interface into a
tokens
field:Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.