Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-api): spec should have error response body #7913

Closed
pujavs opened this issue Mar 1, 2024 · 7 comments
Closed

feat(config-api): spec should have error response body #7913

pujavs opened this issue Mar 1, 2024 · 7 comments
Assignees
@pujavs
Labels
comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request priority-3 Issue or PR is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@pujavs
Copy link
Contributor

pujavs commented Mar 1, 2024 •
edited
Loading

For clients to use and display error message, swagger spec should have response body foe errors as well.

Requested by admin-ui team. Refer Issue 1593
@pujavs pujavs added kind-enhancement Issue or PR is an enhancement to an existing functionality comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR priority-3 Issue or PR is relevant to core functions, but does not impede progress. Important, but not urgent labels Mar 1, 2024
@pujavs pujavs self-assigned this Mar 1, 2024
@mo-auto mo-auto added the kind-feature Issue or PR is a new feature request label Mar 1, 2024
@pujavs pujavs mentioned this issue Mar 1, 2024
Merged
5 tasks
@pujavs
Copy link
Contributor Author

pujavs commented Mar 4, 2024

Fixed via PR 7930

@pujavs pujavs closed this as completed Mar 4, 2024
@duttarnab
Copy link
Contributor

duttarnab commented Mar 5, 2024 •
edited
Loading

Hi @pujavs

for bad password error should be
image
But now it is
image

I am re-opening this issue after facing this issue.

@duttarnab duttarnab reopened this Mar 5, 2024
@duttarnab
Copy link
Contributor

duttarnab commented Mar 5, 2024 •
edited
Loading

Another thing is when an exception is caught the error response body is not returned.

https://github.com/JanssenProject/jans/blob/main/jans-config-api/plugins/user-mgt-plugin/src/main/java/io/jans/configapi/plugin/mgt/rest/UserResource.java#L177

The error response body should be returned. See

https://github.com/JanssenProject/jans/blob/main/jans-config-api/plugins/admin-ui-plugin/src/main/java/io/jans/ca/plugin/adminui/rest/license/LicenseResource.java#L68-L71

https://github.com/JanssenProject/jans/blob/main/jans-config-api/plugins/admin-ui-plugin/src/main/java/io/jans/ca/plugin/adminui/rest/adminui/AdminUIResource.java#L78-L90

@pujavs
Copy link
Contributor Author

pujavs commented Mar 6, 2024

checking this

@pujavs
Copy link
Contributor Author

pujavs commented Mar 6, 2024

Fixed via PR 7979
image

@pujavs
Copy link
Contributor Author

pujavs commented Mar 20, 2024 •
edited
Loading

@duttarnab, this seems to be fixed, request your confirmation on the fix so that i can close the issue

@duttarnab
Copy link
Contributor

Yes this issue fixed. Kindly check this related issue #8034

@pujavs pujavs closed this as completed Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pujavs pujavs

Labels
comp-jans-config-api Component affected by issue or PR effort-3 Relative effort required for completion of issue or PR kind-enhancement Issue or PR is an enhancement to an existing functionality kind-feature Issue or PR is a new feature request priority-3 Issue or PR is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duttarnab @pujavs @mo-auto