Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jans-auth-server): allow invoke consent script by acr #10548

Open
3 tasks
yuriyz opened this issue Jan 4, 2025 · 1 comment · May be fixed by #10712
Open
3 tasks

feat(jans-auth-server): allow invoke consent script by acr #10548

yuriyz opened this issue Jan 4, 2025 · 1 comment · May be fixed by #10712
Assignees
Milestone

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jan 4, 2025

Description

Currently it's invoked based on client configuration. However it shouldn't be problem to introduce new AS configuration property and invoke it based on acr if needed. For example

1. acr1 - consentScript1
2. acr2 - consentScript2
...
n. acrN - consentScriptN

Test cases and code coverage

  • Write unit test to cover added/changed code
  • Update integration tests to cover added/changed code
  • documenation
@yuriyz
Copy link
Contributor Author

yuriyz commented Jan 17, 2025

From #10686 (comment)

What if we add another configuration property that has mapping acr to consent flow like this

agama_io.jans.authn.sms - io.jans.consent.A
agama_io.jans.authn.fido2 - io.jans.consent.B

Algorithm is :

  1. AS got authorization request with acr_values=agama_io.jans.authn.sms
  2. io.jans.authn.sms is run
  3. AS identifies AgamaConsentBridge.py by configuration and also read another configuration property mapping and sets into session with consent_flow=io.jans.consent.A (it should be possible to load with context.getSessionAttributes().get("consent_flow")).

It means we will need two additional configuration mappings.

@moabu moabu modified the milestones: 1.3.0, next-release Jan 21, 2025
yuriyz added a commit that referenced this issue Jan 21, 2025
@yuriyz yuriyz linked a pull request Jan 21, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants