Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jans-cedarling): Update Cedarling Authz interface to use tokens for all JWTs sent as input #10437

Open
1 task
rmarinn opened this issue Dec 17, 2024 · 2 comments · May be fixed by #10521
Open
1 task
Assignees
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Milestone

Comments

@rmarinn
Copy link
Contributor

rmarinn commented Dec 17, 2024

Is your feature request related to a problem? Please describe.

the current shape of the input into cedarling looks like this:

input = { 
  "access_token": "encoded_token_str", 
  "id_token": "encoded_token_str", 
  "userinfo_token": "encoded_token_str", 
  "tx_token": "encoded_token_str",
  "resource": {"id": "12345", "type": "Ticket", "creator": "[email protected]", "organization": "gluu"},
  "action": "View",
  "context": {
    "ip_address": "54.9.21.201",
    "network_type": "VPN",
    "user_agent": "Chrome 125.0.6422.77 (Official Build) (arm64)",
    "time": "1719266610.98636",
  }
}

decision_result = authz(input)

We need to move it into it's own field:

input = { 
  "tokens": {
      "access_token": "encoded_token_str", 
      "id_token": "encoded_token_str", 
      "userinfo_token": "encoded_token_str", 
      "tx_token": "encoded_token_str" 
  },
  "resource": {"id": "12345", "type": "Ticket", "creator": "[email protected]", "organization": "gluu"},
  "action": "View",
  "context": {
    "ip_address": "54.9.21.201",
    "network_type": "VPN",
    "user_agent": "Chrome 125.0.6422.77 (Official Build) (arm64)",
    "time": "1719266610.98636",
  }
}

decision_result = authz(input)

Describe the solution you'd like

  • create a separate param for the tokens called tokens that will be needed when calling authorize

Describe alternatives you've considered
N/A

Additional context
N/A

@rmarinn rmarinn added comp-jans-cedarling Touching folder /jans-cedarling enhancement labels Dec 17, 2024
@rmarinn rmarinn self-assigned this Dec 17, 2024
@mo-auto mo-auto added the kind-enhancement Issue or PR is an enhancement to an existing functionality label Dec 17, 2024
@moabu moabu added this to the next-release milestone Dec 18, 2024
@olehbozhok
Copy link
Contributor

@rmarinn Could you please attach link where it was discussed?

@olehbozhok
Copy link
Contributor

Input should be like described in the attached image
Image

@olehbozhok olehbozhok changed the title refactor(jans-cedarling): move JWTs into the context refactor(jans-cedarling): move JWTs into the token key Dec 19, 2024
@olehbozhok olehbozhok self-assigned this Dec 19, 2024
@nynymike nynymike changed the title refactor(jans-cedarling): move JWTs into the token key refactor(jans-cedarling): Update Cedarling Authz interface to use tokens for all JWTs sent as input Dec 19, 2024
@moabu moabu modified the milestones: 1.2.0, next release Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-cedarling Touching folder /jans-cedarling enhancement kind-enhancement Issue or PR is an enhancement to an existing functionality
Projects
None yet
4 participants