Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move jenkins operations to GH #10082

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

ci: move jenkins operations to GH #10082

wants to merge 3 commits into from

Conversation

moabu
Copy link
Member

@moabu moabu commented Nov 7, 2024

Prepare


Description

Target issue

closes #10081

Implementation Details

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Copy link

dryrunsecurity bot commented Nov 7, 2024

DryRun Security Summary

The provided code changes focus on updating the Janssen Project's build and deployment configuration, primarily integrating the GitHub Packages repository for managing project dependencies and publishing artifacts, without introducing any obvious security vulnerabilities, but requiring careful review to ensure the overall security of the application.

Expand for full summary

Summary:

The provided code changes cover a wide range of updates to the Janssen Project's build and deployment configuration, primarily focused on the integration of the GitHub Packages repository for managing project dependencies and publishing artifacts. These changes do not introduce any obvious security vulnerabilities but require careful review to ensure the overall security of the application.

The key areas to consider from an application security perspective include:

  1. Secure Repository Configuration: Ensure that the GitHub Packages repository is properly secured, with appropriate access controls and authentication mechanisms in place to prevent unauthorized access or tampering with the published artifacts.

  2. Dependency Management: Review the project's dependencies, both direct and transitive, to ensure that they are obtained from trusted sources and do not contain any known vulnerabilities. Regularly update dependencies to the latest secure versions.

  3. Build Process Security: Verify that the build process and publication to the GitHub Packages repository include measures to ensure the integrity of the published artifacts, such as digital signatures or hash verification.

  4. Secure Environment: Maintain a secure build environment, with appropriate access controls, up-to-date software, and robust security practices in place, to mitigate potential risks associated with the development and deployment of the project.

Overall, the changes appear to be focused on improving the project's build and deployment processes, which is a positive step from an application security perspective. However, it is essential to continue monitoring the project's security posture and address any potential vulnerabilities or concerns that may arise during the development and deployment lifecycle.

Files Changed:

The provided code changes span multiple files across the Janssen Project, with the majority of the changes focused on updating the Maven build configuration (pom.xml) files. The key files changed include:

  1. agama/pom.xml: Adds a new GitHub Packages repository for managing project dependencies.
  2. docker-jans-monolith/scripts/entrypoint.sh: Enhances the test preparation and execution process for the Janssen Project's core components.
  3. .github/maven-settings.xml: Introduces a Maven settings file that includes sensitive information, which should be properly secured.
  4. .github/workflows/full-rebuild.yml: Updates the GitHub Actions workflow for the full build of the Janssen Project, including the handling of tests and artifact publication.
  5. jans-auth-server/agama/engine/pom.xml, jans-auth-server/agama/inboundID/pom.xml, jans-auth-server/pom.xml: Adds the GitHub Packages repository configuration to various components of the Janssen Auth Server.
  6. automation/startjanssenmonolithdemo.sh: Provides a script for setting up and running the Janssen Project monolith demo environment.
  7. jans-bom/pom.xml, jans-casa/app-fips/pom.xml, jans-casa/app/pom.xml, jans-casa/plugins/acct-linking/pom.xml, jans-casa/plugins/bioid/pom.xml, jans-casa/plugins/client-authorizations/pom.xml, jans-casa/plugins/custom-branding/pom.xml, jans-casa/plugins/email_2fa_core/pom.xml, jans-casa/plugins/strong-authn-settings/pom.xml, jans-casa/pom.xml: Updates the build and deployment configuration for various Janssen CASA components.
  8. jans-config-api/pom.xml, jans-core/pom.xml, jans-fido2/pom.xml: Adds the GitHub Packages repository configuration to these core Janssen Project components.
  9. jans-keycloak-integration/job-scheduler/pom.xml, jans-keycloak-integration/pom.xml, jans-keycloak-link/pom.xml: Updates the build and deployment configuration for the Janssen Keycloak integration components.
  10. jans-link/server/pom.xml, jans-link/server-fips/pom.xml, jans-link/pom.xml, jans-link/service/pom.xml: Adds the GitHub Packages repository configuration to the Janssen Link components.
  11. jans-lock/lock-server/pom.xml: Adds the GitHub Packages repository configuration to the Jan

Code Analysis

We ran 9 analyzers against 30 files and 1 analyzer had findings. 8 analyzers had no findings.

Analyzer Findings
Sensitive Files Analyzer 25 findings

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added area-CI Issue or changes required in automatic builds or CI infrastructure comp-agama Touching folder /agama comp-docker-jans-monolith comp-jans-auth-server Component affected by issue or PR comp-jans-bom Component affected by issue or PR comp-jans-casa Touching folder /jans-casa comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-keycloak-link Touching folder /jans-keycloak-link comp-jans-link Touching folder /jans-link comp-jans-lock comp-jans-orm Component affected by issue or PR comp-jans-scim Component affected by issue or PR labels Nov 7, 2024
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed for 'keycloak-integration-parent'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Nov 7, 2024

Copy link

sonarcloud bot commented Nov 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CI Issue or changes required in automatic builds or CI infrastructure comp-agama Touching folder /agama comp-docker-jans-monolith comp-jans-auth-server Component affected by issue or PR comp-jans-bom Component affected by issue or PR comp-jans-casa Touching folder /jans-casa comp-jans-config-api Component affected by issue or PR comp-jans-core Component affected by issue or PR comp-jans-fido2 Component affected by issue or PR comp-jans-keycloak-link Touching folder /jans-keycloak-link comp-jans-link Touching folder /jans-link comp-jans-lock comp-jans-orm Component affected by issue or PR comp-jans-scim Component affected by issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: move jenkins operations to GitHub
2 participants