-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jans-fido2): #8901, safetyNet deprecated by Google, android keyst… #8984
Conversation
DryRun Security SummaryThe changes in this GitHub Pull Request remove the Android-specific FIDO2 attestation mechanisms from the Expand for full summarySummary: The changes in this GitHub Pull Request are focused on the From an application security perspective, these changes suggest that the project is no longer supporting the Android-specific FIDO2 attestation mechanisms, either due to security concerns, changes in platform requirements, or a strategic decision to focus on other attestation formats. While the remaining attestation formats still provide a good range of options for developers, the removal of the Android-specific features may impact the functionality or compatibility of the application, depending on its use cases and integrations. It's important to thoroughly review the application's security requirements, use cases, and any potential impact on existing functionality to ensure that these changes do not introduce any unintended security vulnerabilities or regressions. Additionally, the reasons behind the removal of the Android-specific features should be carefully considered to understand the overall security and reliability implications for the FIDO2 implementation. Files Changed:
Code AnalysisWe ran Riskiness🟢 Risk threshold not exceeded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ore had no adoption, therefore removing
Quality Gate passed for 'jans-cli'Issues Measures |
Quality Gate passed for 'jans-linux-setup'Issues Measures |
Quality Gate passed for 'jans-core'Issues Measures |
Quality Gate passed for 'Jans-Keycloak-Link'Issues Measures |
Quality Gate passed for 'jans-config-api-parent'Issues Measures |
Quality Gate passed for 'orm'Issues Measures |
Quality Gate passed for 'Fido2 API'Issues Measures |
Quality Gate passed for 'SCIM API'Issues Measures |
Closing PR. The changes reflect in the |
…ore had no adoption, therefore removing
Prepare
Description
Target issue
#8901
closes #8901
Implementation Details
removing code references
Test and Document the changes
Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with
docs:
to indicate documentation changes or if the below checklist is not selected.Closes #10048,