Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jans-fido2): #8901, safetyNet deprecated by Google, android keyst… #8984

Closed
wants to merge 1 commit into from

Conversation

maduvena
Copy link
Contributor

@maduvena maduvena commented Jul 18, 2024

…ore had no adoption, therefore removing

Prepare


Description

Target issue

#8901

closes #8901

Implementation Details

removing code references


Test and Document the changes

  • Static code analysis has been run locally and issues have been fixed
  • Relevant unit and integration tests have been added/updated
  • Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

  • I confirm that there is no impact on the docs due to the code changes in this PR.

Closes #10048,

Copy link

dryrunsecurity bot commented Jul 18, 2024

DryRun Security Summary

The changes in this GitHub Pull Request remove the Android-specific FIDO2 attestation mechanisms from the jans-fido2 project, suggesting a strategic decision to focus on other attestation formats.

Expand for full summary

Summary:

The changes in this GitHub Pull Request are focused on the AttestationFormat and AttestationErrorResponseType classes in the jans-fido2 project, which is likely a FIDO2 (Fast Identity Online) implementation. The key changes include the removal of the android-key and android-safetynet values from the AttestationFormat enum, as well as the removal of the ANDROID_KEY_ERROR and ANDROID_SAFETYNET_ERROR enum values from the AttestationErrorResponseType class.

From an application security perspective, these changes suggest that the project is no longer supporting the Android-specific FIDO2 attestation mechanisms, either due to security concerns, changes in platform requirements, or a strategic decision to focus on other attestation formats. While the remaining attestation formats still provide a good range of options for developers, the removal of the Android-specific features may impact the functionality or compatibility of the application, depending on its use cases and integrations.

It's important to thoroughly review the application's security requirements, use cases, and any potential impact on existing functionality to ensure that these changes do not introduce any unintended security vulnerabilities or regressions. Additionally, the reasons behind the removal of the Android-specific features should be carefully considered to understand the overall security and reliability implications for the FIDO2 implementation.

Files Changed:

  1. jans-fido2/model/src/main/java/io/jans/fido2/ctap/AttestationFormat.java:
    • The android-key and android-safetynet values have been removed from the AttestationFormat enum.
  2. jans-fido2/model/src/main/java/io/jans/fido2/model/attestation/AttestationErrorResponseType.java:
    • The ANDROID_KEY_ERROR and ANDROID_SAFETYNET_ERROR enum values have been removed from the AttestationErrorResponseType class.

Code Analysis

We ran 9 analyzers against 8 files and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@mo-auto mo-auto added comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality labels Jul 18, 2024
Copy link
Collaborator

@yackermann yackermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

Copy link

sonarcloud bot commented Aug 5, 2024

@maduvena maduvena closed this Nov 5, 2024
@maduvena maduvena reopened this Nov 5, 2024
@maduvena
Copy link
Contributor Author

maduvena commented Nov 5, 2024

Closing PR. The changes reflect in the passkey_project branch

@maduvena maduvena closed this Nov 5, 2024
@mo-auto
Copy link
Member

mo-auto commented Nov 5, 2024

Error: Hi @maduvena, You did not reference an open issue in your PR. I attempted to create an issue for you.
Please update that issues' title and body and make sure I correctly referenced it in the above PRs body.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-jans-fido2 Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
3 participants