Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid pattern misalignment after local affines #8

Open
tatz-murakami opened this issue Dec 8, 2021 · 2 comments
Open

grid pattern misalignment after local affines #8

tatz-murakami opened this issue Dec 8, 2021 · 2 comments

Comments

@tatz-murakami
Copy link

I followed the example bigstream_intro_tutorial jupyter notebook with the default parameters.
The registration looks fine after global affine. However, weird grid pattern misalignment appeared after local affines.
This happens even if I define local affines filled with identity matrices.
I am not familiar with dask, but I suspect the merging of overlapping regions between chunks is causing the problem.

global affine
global_affine

global + local affines
total_affine
@MathieuBo
Copy link

Hello,
I obtained a similar issue. Did you find a way to resolve it?

Thanks!

orena1 added a commit to orena1/dask_stitch that referenced this issue Sep 22, 2022
@orena1
off by one bug
e4bed17 
To take the edge, one need to go all the way to None, and not to zero. 
e.g.
[0,1,2,3,4,5,6][slice(3,0,1)] -- > [3, 2, 1]

[0,1,2,3,4,5,6][slice(3,None,1)] --> [3, 2, 1, 0]

See also:
JaneliaSciComp/bigstream#8
@orena1 orena1 mentioned this issue Sep 22, 2022
Open
@orena1
Copy link
Contributor

orena1 commented Sep 22, 2022

Hi @MathieuBo and @tatz-murakami
From what I can tell there is a off-by-one bug in dask_stitch, I've fixed it and it looks fine:
image

See bug fix @GFleishman
GFleishman/dask_stitch#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@orena1 @MathieuBo @tatz-murakami