Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: Eliminate obvious overhead from metrics computation #96

Closed
cmalinmayor opened this issue Oct 31, 2023 · 2 comments
Closed
Labels
performance Changes that impact runtime and performance
Milestone

Comments

@cmalinmayor
Copy link
Collaborator

At a minimum, get back to speed that Ben experienced previously. @bentaculum can you put the commit hash here for reference?

@cmalinmayor cmalinmayor added the enhancement New feature or request label Oct 31, 2023
@cmalinmayor cmalinmayor added this to the Version 1.0 milestone Oct 31, 2023
@bentaculum
Copy link
Contributor

Sure, here it is, from #57. f8c982c. I don't know how the current main compares to this, we'd have to run the benchmarks once retroactively on that commit somehow.

@cmalinmayor
Copy link
Collaborator Author

Thanks @bentaculum! I plan to manually run the benchmarking to debug the issues I have introduced and make a manual comparison, I'll add that here when I have it. Maybe adding a profiling tool at this point is worth the effort - I'll look into it as well. Of course, if you get to it first, the more the merrier :)

@msschwartz21 msschwartz21 added performance Changes that impact runtime and performance and removed enhancement New feature or request labels Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Changes that impact runtime and performance
Projects
Status: Done
Development

No branches or pull requests

3 participants