Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Best way to) Avoid ragged error annotations on graph #129

Open
6 of 14 tasks
cmalinmayor opened this issue Dec 5, 2023 · 1 comment
Open
6 of 14 tasks

(Best way to) Avoid ragged error annotations on graph #129

cmalinmayor opened this issue Dec 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@cmalinmayor
Copy link
Collaborator

cmalinmayor commented Dec 5, 2023

Description

We want to annotate the NodeFlags and EdgeFlags on all nodes/edges. The CTC errors currently do this, but the divisions do not. We need to determine where to first set all Flags to a default value - TrackingGraph initialization, or start of error annotation. And then implement the solution and add documentation.

Topics

What types of changes are you suggesting? Put an x in the boxes that apply.

  • New feature or enhancement
  • Documentation update
  • Tests and benchmarks
  • Maintenance (e.g. dependencies, CI, releases, etc.)

Which topics does your change affect? Put an x in the boxes that apply.

  • Loaders
  • Matchers
  • Track Errors
  • Metrics
  • Core functionality (e.g. TrackingGraph, run_metrics, cli, etc.)

Priority

  • This is an essential feature
  • Nice to have
  • Future idea

Are you interested in contributing?

  • Yes! 🎉
  • No 🙁
@msschwartz21
Copy link
Collaborator

msschwartz21 commented Nov 25, 2024

At the beginning of the error class, all nodes/edges should have all flags applied with the default value. As cases are examined the value should be flipped accordingly.

Caroline and I went back and forth on this, but for now I think we are going to continue with ragged annotations until a use case emerges that will break with ragged annotations. In the meantime, we will improve documentation about the flags so that it is clear what a missing flag means.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants