Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing includes #3

Open
mPorst opened this issue Jun 1, 2019 · 5 comments
Open

missing includes #3

mPorst opened this issue Jun 1, 2019 · 5 comments

Comments

@mPorst
Copy link

mPorst commented Jun 1, 2019

Hello,
Let me first say that this project is absolutely amazing and I am very grateful that you uploaded this to github !
I cloned the repo but was not immediately able to build. Apparently there were missing includes, I fixed it adding:
#include in bwImageHeightMap/ImageSourceChunkFactory.h
#include in voxelEngine/ShaderManager.h
Built in Visual Studio Community 2019, version 16.1.1

On first setup I also encountered an error telling me that I do not have the right windows sdk installed. Reloading the .sln a prompt appeared asking me if I wanted to install the proper sdk version for this which eventually fixed the bug.

If you wish I can do a pull request for the 2 includes (if it is really a bug)

Best regards
Moritz

@awalvie
Copy link

awalvie commented Aug 7, 2019

Can you please specify how you fixed the missing includes ? I'm also having problems directly building on Visual Studio Community 2019

@mPorst
Copy link
Author

mPorst commented Aug 13, 2019

Can you specify your problem ? I described in detail what I did in my issue to fix it, so I don't know what to tell you.

@awalvie
Copy link

awalvie commented Aug 13, 2019

I specifically don't understand these 2 lines

#include in bwImageHeightMap/ImageSourceChunkFactory.h
#include in voxelEngine/ShaderManager.h

If possible could you let me know what Includes I'm supposed to add in which header/source file I'd be very grateful ?

@mPorst
Copy link
Author

mPorst commented Aug 13, 2019

Oh no, actually I can't use the < and > to embed text into them. I use square brackets as a workaround:
it is #include [string] in ImageSourceChuckFactory.h
and #include [stdexcept] in ShaderManager.h
Try it out, this should work.

@awalvie
Copy link

awalvie commented Aug 13, 2019

Thanks a lot, will check and let you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants