Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "single-page apps" that divorce location.pathname from main_frame requests #19

Open
James-E-A opened this issue Sep 27, 2020 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@James-E-A
Copy link
Owner

James-E-A commented Sep 27, 2020

The current code works great for apps that respect the URL metaphor by only using the fragment to represent its internal state (e.g. VMWare ESXi web UI), but breaks down for apps that completely commandeer it via JavaScript (e.g. Discourse, Discord, GitHub)

@James-E-A James-E-A added the help wanted Extra attention is needed label Oct 2, 2020
@James-E-A James-E-A changed the title Support "single-page apps" that divorce window.location from HTTP requests Support "single-page apps" that divorce location.pathname from main_frame requests Oct 5, 2020
@James-E-A
Copy link
Owner Author

The right(?) way to do this is, I guess:

  • If we have not yet seen that host on that tab, use it
  • If the request is main_frame, use it

Tangentially: consider blocking + sounding the alarm on requests which match the hostname, but not the certificate, of the last request in its tab matching the above criteria

@TJesionowski got any ideas?

@James-E-A James-E-A added the good first issue Good for newcomers label Mar 8, 2021
@James-E-A
Copy link
Owner Author

Better yet: figure out whence the data for "what's shown if you click on the lock in the URL bar" is got, especially for PWAs that may run fully-offline.

@James-E-A
Copy link
Owner Author

Seems to have been fixed in 3a9048c when we switched to matching by host instead of whole-URL

@James-E-A
Copy link
Owner Author

Nevermind; this is still present for offline PWAs. Does anybody know how to getSecurityInfo() for ServiceWorker-managed requests? (The Security tab in the devtools networkmonitor is populated…)

@James-E-A James-E-A reopened this May 30, 2021
@James-E-A
Copy link
Owner Author

Does anybody know how to getSecurityInfo() for ServiceWorker-managed requests?

No bites yet: https://discourse.mozilla.org/t/getsecurityinfo-for-pwas/81239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant