This repository has been archived by the owner on Sep 10, 2020. It is now read-only.
Move OverlayView to below the status bar on Oreo+ #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saket
changed the title
|
I foresee a problem where the overlay view now blocks touch targets in the app below (particularly action items) |
|
I just realized that the |
|
Just tried this out; this works well for me. @raveeshbhalla is probably right that this will make it tricky to hit the app's UI behind the controls. But right now it isn't functional at all on Oreo. This fix at least gets it going again for some/most apps. |
|
Someone suggested using the power button to stop and then waking the screen
right back up and dismissing the keyguard. I thought that was interesting
since it means no magic transparent UI to hit.
I'm always annoyed when the last frame of my video has a touch circle in
the upper-right!
…On Fri, Sep 22, 2017 at 5:03 PM Craig Russell ***@***.***> wrote:
Just tried this out; this works well for me.
@raveeshbhalla <https://github.com/raveeshbhalla> is probably right that
this will make it tricky to hit the app's UI behind the controls.
But right now it isn't functional at all on Oreo. This fix at least gets
it going again for some/most apps.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEQnwVA4Nu9rZhEoktyKHUIFJhbaZks5slCCigaJpZM4PXhtm>
.
|
|
Shake to stop? 😀
…On Fri, Sep 22, 2017, 22:06 Jake Wharton ***@***.***> wrote:
Someone suggested using the power button to stop and then waking the screen
right back up and dismissing the keyguard. I thought that was interesting
since it means no magic transparent UI to hit.
I'm always annoyed when the last frame of my video has a touch circle in
the upper-right!
On Fri, Sep 22, 2017 at 5:03 PM Craig Russell ***@***.***>
wrote:
> Just tried this out; this works well for me.
>
> @raveeshbhalla <https://github.com/raveeshbhalla> is probably right that
> this will make it tricky to hit the app's UI behind the controls.
>
> But right now it isn't functional at all on Oreo. This fix at least gets
> it going again for some/most apps.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#165 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAEEEQnwVA4Nu9rZhEoktyKHUIFJhbaZks5slCCigaJpZM4PXhtm
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABRj2dJkwDkZgQ_6i5ZaO91CcyKTXAjrks5slCFPgaJpZM4PXhtm>
.
|
|
Turning off the display doesn't sound like a very good experience and I might be wrong, but dismissing the keyguard is only possible if there is no lock, right? What do you folks think of pressing both the volume buttons instead? |
|
I haven't ever worked on capturing the display, so probably a naive thought, but how does the screen capturing work with secure views? Any chance you could leave the start/stops controls visible but mark them as secure views somehow, and the screen recording will magically omit them in the output video? |
|
@CDRussell I think we'll have to then make the overlay draggable then so that it doesn't block the UI. |
|
Yeah that's where I was heading with that idea. But I'm not convinced that it would even work. Think the "secure" views might result in black areas in the video, rather than seeing the original app. |
|
Any app can dismiss the keyguard with permission.
I do not want draggable controls.
…On Sat, Sep 23, 2017, 12:34 PM Craig Russell ***@***.***> wrote:
Yeah that's where I was heading with that idea.
But I'm not convinced that it would even work. Think the "secure" views
might result in black areas in the video, rather than seeing the original
app.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEEEdydLBNeag1-8LUmV-8jNZ9-U9v-ks5slTMNgaJpZM4PXhtm>
.
|
|
A volume button hold for a small amount of time (between 1-3 seconds) seems
like a good alternative that shouldn't cause any interruptions with the
rest of the system or apps. No permissions required and no weirdness of
screen turning off.
On Sat, Sep 23, 2017, 10:15 PM Jake Wharton <[email protected]>
wrote:
Any app can dismiss the keyguard with permission.
I do not want draggable controls.
On Sat, Sep 23, 2017, 12:34 PM Craig Russell ***@***.***>
wrote:
> Yeah that's where I was heading with that idea.
>
> But I'm not convinced that it would even work. Think the "secure" views
> might result in black areas in the video, rather than seeing the original
> app.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#165 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AAEEEdydLBNeag1-8LUmV-8jNZ9-U9v-ks5slTMNgaJpZM4PXhtm
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#165 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABwdU4bN31iM1IsKuHbRtdXJQBDtJIQAks5slTWvgaJpZM4PXhtm>
.
--
~
Raveesh
+9711907427
I tinker, therefore I am
|
Open
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the overlay below the status bar by applying a top-padding to the View's content.
I initially wanted to do this by modifying the
WindowManager.LayoutParams#yvalue inonApplyWindowInsets()instead, but that triggers a secondonApplyMethodInsets()call with a different value forWindowInsets#getSystemWindowInsetTop()and I am not sure how to avoid/deal with that.Fixes #149.