Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Do not show AI tabs" to AI tabs #11707

Open
ilippert opened this issue Sep 5, 2024 · 10 comments
Open

Add "Do not show AI tabs" to AI tabs #11707

ilippert opened this issue Sep 5, 2024 · 10 comments
Labels
AI Related to AI Chat/Summarization good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Milestone

Comments

@ilippert
Copy link
Contributor

ilippert commented Sep 5, 2024

JabRef 5.16--2024-08-29--70d7c9c
Linux 6.10.7-200.fc40.x86_64 amd64
Java 21.0.2
JavaFX 22.0.2+4

I appreciate the developers' integration of AI tools into JabRef, but I like to see the option of opting out (which is already implement within the preferences ui), but in the entry details, the tabs for AI seemingly cannot be removed. For me these are a distraction.

I suggest that users can enable/disable the AI tabs in the preferences, UI, too.

@ilippert ilippert changed the title if AI is not used, thenm don't show AI summary&chat if AI is not used, then don't show AI summary&chat Sep 5, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Features & Enhancements Sep 5, 2024
@koppor
Copy link
Member

koppor commented Sep 5, 2024

Maybe add a button "disable AI tabs" in these tabs if AI is not activated @InAnYan

@ilippert We had discussion, where to put the settings of showing the tabs. To the other settings of showing/hiding tabs or to the AI. We did not want to double. We placed it to the other tabs

grafik

@koppor koppor changed the title if AI is not used, then don't show AI summary&chat Add "Do not show AI tabs" to AI tabs Sep 5, 2024
@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Sep 5, 2024
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Sep 5, 2024
@koppor koppor added this to the 6.0-beta milestone Sep 5, 2024
@koppor koppor added the AI Related to AI Chat/Summarization label Sep 5, 2024
@Manan5994
Copy link

Manan5994 commented Sep 14, 2024

@koppor, can I pick this one?

@koppor koppor added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Sep 14, 2024
@koppor koppor moved this from Free to take to Reserved in Good First Issues Sep 14, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@ilippert
Copy link
Contributor Author

Maybe add a button "disable AI tabs" in these tabs if AI is not activated @InAnYan

If the preferences interface allows links, I would prefer in the AI section a link to the Entry Editor preferences. The reasoning is: a user might have once have AI activated, stored some information; and even after deactivating AI, might want to be able to view said AI generated information.

@koppor
Copy link
Member

koppor commented Sep 14, 2024

To solve the issue, add a button on the two tabs:

image

When pressed, the preferences should be changed to not show the two tabs again. And the tabs should be hidden. (You can check how it works in other parts of the code when tabs visibility is changed. IMHO the whole entry editor is hidden then and reinitialized later)

Bonus 1 : Add a tab "Hide 'Related articles' tab" to "Related articles":

image

Bonus 2: Add the privacy agreement functionality and tab hiding functionality to tab "Citation Information"

Bonus 3: Add the privacy agreement functionality and tab hiding functionality to tab "Citation relations"

Bonus 4: Reorder tab settings in entry editor settings following the order in the entry editor

Current ordering does not match at all: 😅

image

You can file separate pull requests for each issue (Remember to create a new branch based on main for each thing you tackle)

@koppor
Copy link
Member

koppor commented Oct 15, 2024

@Manan5994 There was no activity the last 4 weeks, so I assume this is free to take again.

@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Oct 15, 2024
@koppor koppor moved this from Assigned to Free to take in Good First Issues Oct 15, 2024
@Simon7878912
Copy link

Hi Koppor, I am very interested in this issue, would you like to assign it to me? Thank you

@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) FirstTimeCodeContribution Triggers GitHub Greeter Workflow labels Oct 15, 2024
Copy link
Contributor

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) and removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) labels Oct 15, 2024
@koppor koppor moved this from Free to take to Assigned in Good First Issues Oct 15, 2024
@koppor koppor added 📍 Assigned Assigned by assign-issue-action (or manually assigned) and removed 📍 Assigned Assigned by assign-issue-action (or manually assigned) labels Oct 15, 2024
@koppor
Copy link
Member

koppor commented Nov 11, 2024

/unassign @Simon7878912

Copy link
Contributor

👋 Hey @Simon7878912, you've been automatically unassigned from this issue due to inactivity.

Note

If you'd like to be re-assigned, just leave another comment or ask a maintainer to assign you again.
If you're still actively working on the issue, let us know by commenting, and we can pin it to prevent automatic unassignment.

@koppor koppor moved this from Assigned to Free to take in Good First Issues Nov 11, 2024
@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Related to AI Chat/Summarization good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
Status: Free to take
Status: Normal priority
Development

No branches or pull requests

5 participants