-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PspA figure implementation #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved things around a bit to at least clean up towards a working function. It's clearly not quite there yet. I hope this helps as a start.
I need a little help, @the-mayer @epbrenner -- thanks!
Hey @jananiravi, thanks for the review. Would it be alright if I committed your suggestions? They all seem reasonable to me. (Well, since Also, I was planning to create a new PR in https://github.com/JRaviLab/molevol_scripts with this PR's contents. I had originally created PRs here for each figure so our contributors could work on it, but since no one took it on and it's needed for the rebuttal I was thinking it'd be faster to get it merged into If that's all OK with you I'll start working on that, and I'll do the same for DciA and InlP. |
Co-authored-by: Janani Ravi <[email protected]>
Sounds good, Faisal. If you have any additional questions, please feel free to tag @epbrenner and me, and we will get back to you ASAP. Thanks! |
Description
This PR contains a very work-in-progress implementation of figure 4 from the PspA paper, https://journals.asm.org/doi/epub/10.1128/msystems.00847-23. The PR
is intended as a starting point, so you don't have to go and find the original code from the papers, but it definitely needs a lot of work! See issue #90 for more details.
Closes #90.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.