-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ONNX operators needed to be supported #17
Comments
Constant operator |
PReLU has been supported in #23 @AmienKhaled I'll implement it soon |
In version 0.6.0, identity, prelu and constant op should be supported (please also use the latest onnx2daq) |
Reshape can only be the last layer |
@ericdanz reshape layer is somewhat special due to the difference between nhwc(nnapi) and nchw(onnx) layout. I think there is no general, simple way to implement reshape layer, and most reshape layers in an onnx model are indeed generated implicitly. Could you please provide your model so that I can analyze it? |
I can share the onnx file. Quick warning - it's a bit complicated ;) There are a few places reshape is used, in my special batchnorm and shuffle-net like layers. |
@ericdanz Thanks for your model. Unfortunately, the reshape here is hard to implement in nnapi. I'll open another issue to track it. However, it may be a long-term work. |
Concat is causing some problems - had to disable the shape checking in shaper.cpp Upsample is also not supported yet. Made a model that is compatible, about to test it out! Very excited to see more and more ops supported ;) |
Thanks for your valuable information!
I will look into it today (It is 7:06 AM, GMT+8 here XD)
Thanks again!
…On Tue, Jan 29, 2019, 4:08 AM ericdanz ***@***.*** wrote:
Concat is causing some problems - had to disable the shape checking in
shaper.cpp
Upsample is also not supported yet.
Made a model that is compatible, about to test it out! Very excited to see
more and more ops supported ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ALEcn6OwqZ0UXXKevlqqWEUYgcwGG6lvks5vH1i3gaJpZM4ZM5hH>
.
|
|
@ericdanz @daquexian Do you happen to have such large pytorch model that could be further optimized after ONNX export? |
This issue is to summarize all operators which needed to be supported. If you want an operator to be supported, please feel free to post it here.
The text was updated successfully, but these errors were encountered: