-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactorings to simplify FireMonkey port #841
Comments
All looks ok but
but this one should stay. I use it myself. |
I can change all to alias TDimension but two questions
I see more problems here. |
Changing published properties should not be breaking, so yes. For the events we should consider waiting to the next major version of Virtual TreeView. It will work, but the IDE will show an (unnecessary) warning. I wonder: Is Firemonkey making actual use of the decimal places that the A V8.0 might be a good point to finally merge the branches and make such small breaking changes. There is another event that should be changed (#837). |
changes commited
It depend of usage case. Normally we have fraction=0 but you can have some scalling and any calculation can be made by fraction. |
Not sure how to get these changes and leave out all your other changes. I will apply them manually in master branch at a later time. |
I suppose you can cherry-pick this particular commit |
Added support of header drawing - its columns and button styles |
Added some click events, expand, collapse, header column resize, focus rect.. |
See pull request #839 for a detailed discussion. Proposed changes:
$ifdef
in the code.HDC
, we should try to switch toTCanvas
instead.TVTDataObject
,VTDRagManager
etc. to own unit.The text was updated successfully, but these errors were encountered: