Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad handling of path parameters in a Linux environment #55

Open
ghost opened this issue Jan 26, 2016 · 2 comments
Open

Bad handling of path parameters in a Linux environment #55

ghost opened this issue Jan 26, 2016 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 26, 2016

Under Msbuild.groovy we have the code

        ['OutDir', 'OutputPath', 'BaseIntermediateOutputPath', 'IntermediateOutputPath', 'PublishDir'].each {
            if (cmdParameters[it] && !cmdParameters[it].endsWith('\\')) {
                cmdParameters[it] += '\\'
            }
        }

which doesn't look right on a Unix environment.
I have a case similar to the documented help:

// overrides project OutputPath
destinationDir = 'build/msbuild/bin'
// overrides project IntermediaryOutputPath
intermediateDir = 'build/msbuild/obj'

These paths will be modified to contain a '' in the end, causing the output to be copied to the wrong directory with the wrong name, e.g. (file 'bin\some_lib.dll' will be placed under build/ instead of build/bin/some_lib.dll)

@novabyte
Copy link

novabyte commented May 6, 2016

I have this problem as well. What is the intention behind adding \\ to the output paths?

@gluck
Copy link
Contributor

gluck commented May 6, 2016

as far as I remember this was required because msbuild tasks on windows didn't append the separator automatically (and generated paths using string concat were completely off).
One would have to check if mono msbuild also requires this, and either add the proper sep for mono, or not add it at all.

Any idea which case it is ?

@gluck gluck added the bug label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants