Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] An empty new line shows up in place of the “Volume: X sold in the last 24 hours” text if you've clicked on a booster pack in your Steam inventory that wasn't sold in the last 24 hours #2107

Open
przemo20 opened this issue Dec 31, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@przemo20
Copy link
Contributor

przemo20 commented Dec 31, 2024

Expected Behavior

If the booster pack wasn't sold at all in the last day, the “Volume: X sold in the last 24 hours” text nor an empty line placeholder should be present at all, or it should just say, “Volume: 0 sold in the last 24 hours”.

Actual Behavior

obraz

I believe this got broken by PR #2003 – if I load up the version 3.1.1 in Chrome, that placeholder line doesn't show up.

Just a little off-topic: this placeholder line seems to also show up if you click on a different item type, like an emoticon, but it doesn't look “that bad” (?), like some text is missing:
obraz

Steps to Reproduce the Problem

  1. Go to https://steamcommunity.com/my/inventory#753
  2. Click on a booster pack that wasn't sold in the last 24 hours

Specifications

  • Augmented Steam Version: 4.2.1
  • Browser Version: Google Chrome 131.0.6778.205 (64-bit)
@przemo20 przemo20 added the bug Something isn't working label Dec 31, 2024
@candela97
Copy link
Collaborator

"Volume: X sold in the last 24 hours" is handled by Steam, so this isn't a regression. I knew this empty line could sometimes appear when I fixed the other issue, and it can be fixed with CSS, but I didn't think it's worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants