Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Don't show again" button on "Make sure that you are logged in" banner has no effect #2104

Open
Terrance opened this issue Dec 28, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@Terrance
Copy link
Contributor

Expected Behavior

Dismissing this banner via Don't show again should be remembered, and it shouldn't show again.

Actual Behavior

The banner reappears on every page.

Context

I'm constantly seeing the "Make sure that you are logged into steamcommunity.com" banner prompt within steamcommunity.com itself (not the store):

image

I use Firefox with strong privacy features enabled, which I understand can cause interaction issues between Steam's domain (#818). I've yet to figure out exactly what isn't working though -- the (!) icon claims two failed requests, but the console doesn't offer much context and there are no failed HTTP requests that I can see:

Augmented Steam v4.2.1  https://augmentedsteam.com/
    [Page.ts:92:16](moz-extension://c5a2ee31-d569-4155-a365-18407ba3ef5f/src/js/Content/Features/Page.ts)
Feature loading complete, 11 successfully loaded, 0 failed to load, 0 didn't load due to dependency errors
    [Context.ts:59:16](moz-extension://c5a2ee31-d569-4155-a365-18407ba3ef5f/src/js/Content/Modules/Context/Context.ts)
Error: LoginError: community
    [undefined](chrome://devtools/content/webconsole/undefined)

However, I've yet to see any obvious signs of breakage (presumably just one or more features not loading at all) so this hasn't really been an issue. The banner is a minor nuisance though, as I can't seem to dismiss it in any permanent way.

Steps to Reproduce the Problem

  1. Visit steamcommunity.com with a configuration that causes the banner
  2. Click Don't show again
  3. Reload or visit another page
  4. Banner shows again

Specifications

  • Augmented Steam Version: 4.2.1
  • Browser Version: Firefox 134
@Terrance Terrance added the bug Something isn't working label Dec 28, 2024
@magnuspraeda
Copy link

I am experiencing this issue as well and I am also at a loss as to what exactly is failing to load and, similarly, cannot get the banner to go away between pages or reloads.

@Daniel-Chalil
Copy link

I've had this error before sporadically. I tried examining the console and found the two errors to be for "hn" and "LoginError", however I too was unable to find any root cause in the files to show the cause for it.

I signed out of steam, deleted all cookies/local storage (for both store and community pages) and attempted to recreate the error to no avail. I also tried recreating the error in another session/browser with signing in into store only, community only and both concurrently however that didn't seem to recreate the bug either even after several days of trying.

you can try resetting the cookies/storage and see if that fixes the issue, and in the meanwhile if anyone was able to find steps to reproduce this bug reliably, I would be interested in knowing to track this down further.

@Ranshye
Copy link

Ranshye commented Jan 9, 2025

Idk how much help is that but for me one of the features failed was "hn" which is supposedly related to the coupons.
Also I was somehow disconnected from IsThereAnyDeal and the moment I connected the banner disappeared and no more failed features.

@candela97
Copy link
Collaborator

Quoting myself:
The community login error only affects features that make cross-origin requests to the community. The only ones left I believe are show applicable coupons and highlight games with available coupons/gifts etc., so you can disable them if you don't want to see this error, or make sure to visit any community page every 24 hours.

"Don't show again" not working was an issue before but it was quite some time ago and the extension has changed a lot since then. I'll have to check what's going on 😅

@candela97 candela97 self-assigned this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants