Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 SPOs Vote count shown instead of voting power #2085

Closed
kneerose opened this issue Sep 27, 2024 · 0 comments · Fixed by #2137
Closed

🐛 SPOs Vote count shown instead of voting power #2085

kneerose opened this issue Sep 27, 2024 · 0 comments · Fixed by #2137
Assignees
@jdyczka @MSzalowski
Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Milestone
🏛 Needed for Full...

Comments

@kneerose
Copy link
Contributor

kneerose commented Sep 27, 2024 •
edited
Loading

Area

Voting Pillar

Domain

dev-sanchogov.tools

Which wallet were you using?

No response

Context

The SPOs Vote count shown for governance actions instead of count. According to CIP-1694, SPOs should be shown voting power proportional to the amount of Lovelace delegated, not shown as a simple count.

Steps to reproduce

  1. Navigate to any governance action.
  2. Observe the SPOs vote representation.

Actual behavior

The SPOs Vote count is displayed instead of voting power proportional to the Lovelace.

Screenshot from 2024-09-27 11-25-26

Expected behavior

The SPOs vote should be displayed proportional to the amount of Lovelace delegated, as specified in CIP-1694.

Allure Report
@kneerose kneerose added the 🐛 Bug Something isn't working label Sep 27, 2024
@kneerose kneerose changed the title 🐛 sPos Voting is Represented in Count Instead of Vote Proportional to Lovelace 🐛 SPOs Voting is Represented in Count Instead of Vote Proportional to Lovelace Sep 27, 2024
@kneerose kneerose changed the title 🐛 SPOs Voting is Represented in Count Instead of Vote Proportional to Lovelace 🐛 SPOs Vote count shown instead of voting power Sep 27, 2024
@kneerose kneerose mentioned this issue Oct 1, 2024
Closed
7 tasks
@bosko-m bosko-m moved this to To do in Govtool all Oct 8, 2024
@bosko-m bosko-m assigned jdyczka and MSzalowski and unassigned bosko-m Oct 9, 2024
@MSzalowski MSzalowski moved this from To do to In progress in Govtool all Oct 10, 2024
MSzalowski added a commit that referenced this issue Oct 10, 2024
@MSzalowski
fix(#2085): fix counting SPO votes
16c48e5
MSzalowski added a commit that referenced this issue Oct 10, 2024
@MSzalowski
fix(#2085): fix counting the SPO votes
c342be7
@MSzalowski MSzalowski linked a pull request Oct 10, 2024 that will close this issue
fix(#2085): fix counting the SPO votes #2137
Merged
5 tasks
@MSzalowski MSzalowski mentioned this issue Oct 10, 2024
Merged
5 tasks
@MSzalowski MSzalowski moved this from In progress to In staging in Govtool all Oct 10, 2024
@MSzalowski MSzalowski moved this from In staging to In review in Govtool all Oct 10, 2024
MSzalowski added a commit that referenced this issue Oct 10, 2024
@MSzalowski
fix(#2085): fix counting the SPO votes
54d7fca
MSzalowski added a commit that referenced this issue Oct 10, 2024
@MSzalowski
Merge pull request #2137 from IntersectMBO/fix/2085-spos-vote-count-s…
11bb2f7 
…hown-instead-of-voting-power

fix(#2085): fix counting the SPO votes
@github-project-automation github-project-automation bot moved this from In review to Done in Govtool all Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdyczka jdyczka

@MSzalowski MSzalowski

Labels
🐛 Bug Something isn't working 🗳️ Voting Pillar
Projects
Governance Tools Community Backlog
Status: Done
Govtool all
Status: Done
Milestone
🏛 Needed for Full governance / Mainnet
Development

Successfully merging a pull request may close this issue.

fix(#2085): fix counting the SPO votes IntersectMBO/govtool
4 participants
@jdyczka @MSzalowski @kneerose @bosko-m