Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix babbage-test and conway-test versions #4333

Merged
merged 2 commits into from
May 13, 2024

Conversation

Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented May 11, 2024

They were not updated when some dependency version bounds were bumped.

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Lucsanszky Lucsanszky changed the title Fix cardano-ledger-babbage-test version Fix babbage-test and conway-test versions May 13, 2024
It was not updated when some dependency version bounds were bumped.
It was not updated when some dependency version bounds were bumped.
@Lucsanszky Lucsanszky force-pushed the ldan/update-babbage-test-version branch from 0c11835 to 359b141 Compare May 13, 2024 03:03
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we have to release these two to CHaP as well, no?

@disassembler disassembler merged commit 83625e9 into master May 13, 2024
125 checks passed
@disassembler disassembler deleted the ldan/update-babbage-test-version branch May 13, 2024 13:09
@Lucsanszky
Copy link
Contributor Author

I guess we have to release these two to CHaP as well, no?

Indeed! Sam already opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants