Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality of life and helper callback functions #237

Merged
merged 32 commits into from
Jul 1, 2024
Merged

Quality of life and helper callback functions #237

merged 32 commits into from
Jul 1, 2024

Commits on Jul 1, 2024

  1. refactor: ruff fixes and adding fractional coordinate check

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7abff49 View commit details
    Browse the repository at this point in the history

  2. feat: added embedding forward hook check 

    Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0e4e8bc View commit details
    Browse the repository at this point in the history

  3. feat: added encoder forward hook to helper

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a433685 View commit details
    Browse the repository at this point in the history

  4. feat: added encoder-outputhead compaison

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7759f09 View commit details
    Browse the repository at this point in the history

  5. feat: working grad norm logging

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7221eff View commit details
    Browse the repository at this point in the history

  6. refactor: changing variance value to a much smaller value

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    17297f2 View commit details
    Browse the repository at this point in the history

  7. docs: adding docstrings throughout helper 

    Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    4372d75 View commit details
    Browse the repository at this point in the history

  8. feat: added function to log embeddings

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1a84d16 View commit details
    Browse the repository at this point in the history

  9. feat: adding embedding logging call

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    552cf1b View commit details
    Browse the repository at this point in the history

  10. refactor: using hparams for log embedding kwarg

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9922415 View commit details
    Browse the repository at this point in the history

  11. fix: adding global step specification in tensorboard embedding log

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2349305 View commit details
    Browse the repository at this point in the history

  12. refactor: adding global step to add embedding

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1a749be View commit details
    Browse the repository at this point in the history

  13. refactor: making forward generically stash embeddings

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cac78fe View commit details
    Browse the repository at this point in the history

  14. refactor: putting embedding logging in train step 

    That way we don't do a double log as forward might be called multiple times
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    53d640b View commit details
    Browse the repository at this point in the history

  15. refactor: adding embedding logging to independent steps

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d7e1f07 View commit details
    Browse the repository at this point in the history

  16. chore: rebasing main to finalize PR

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    997a1be View commit details
    Browse the repository at this point in the history

  17. refactor: added log embedding frequency control

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1640ef8 View commit details
    Browse the repository at this point in the history

  18. refactor: cleaned up log_embeddings function

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a9dd125 View commit details
    Browse the repository at this point in the history

  19. test: added simple unit test for forward hook 

    Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7186df6 View commit details
    Browse the repository at this point in the history

  20. feat: implemented working autocorrelation callback

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    44150f5 View commit details
    Browse the repository at this point in the history

  21. docs: added a variety of docstrings for model autocorrelation

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    8eb876f View commit details
    Browse the repository at this point in the history

  22. docs: added docstring for helper callback

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    9c48a5c View commit details
    Browse the repository at this point in the history

  23. scripts: added scripts to demonstrate callback usage 

    Signed-off-by: Lee, Kin Long Kelvin <[email protected]>
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a8ccae8 View commit details
    Browse the repository at this point in the history

  24. refactor: using cartesian coordinates as regular inputs

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    28e1a33 View commit details
    Browse the repository at this point in the history

  25. refactor: taking absolute value of the median for comparison

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    af745c0 View commit details
    Browse the repository at this point in the history

  26. refactor: now looping over multiple loggers, if any are supplied 

    This will only still function for wandb/tensorboard, but supports multiple
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    515e4b8 View commit details
    Browse the repository at this point in the history

  27. refactor: making forward pass only set embeddings to batch, not reusi… 

    …ng them

This addresses the issue of computational graphs breaking
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7f726b9 View commit details
    Browse the repository at this point in the history

  28. fix: nesting scheduler stepping mechanism only if something is passed

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b888ee8 View commit details
    Browse the repository at this point in the history

  29. refactor: allowing multi task subtasks to reuse shared embedding

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c182d90 View commit details
    Browse the repository at this point in the history

  30. refactor: adding log embeddings kwargs to multi task litmodule

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2ca1367 View commit details
    Browse the repository at this point in the history

  31. feat: added log embeddings method to multitask litmodule

    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    43175b4 View commit details
    Browse the repository at this point in the history

  32. refactor: logging embeddings for both training and validation steps i… 

    …n multitas
    @laserkelvin
    laserkelvin committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d53cde4 View commit details
    Browse the repository at this point in the history