Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Advanced Report Hack and merge it with Yellow Card #62

Open
vendethiel opened this issue Dec 14, 2018 · 21 comments
Open

Add Advanced Report Hack and merge it with Yellow Card #62

vendethiel opened this issue Dec 14, 2018 · 21 comments

Comments

@vendethiel
Copy link
Collaborator

I won't beat around the bush. The card mod is too dated, not intuitive, and not very helpful.

S2B's Advanced Report Hack mod looks very potent, and I'd like to integrate it, so that IntegraMOD can have real reporting tools.
What do you think?

@vendethiel
Copy link
Collaborator Author

vendethiel commented Dec 20, 2018

Obviously I have to deal with PCP, as this modifies quite a bit of usercp_viewprofile.. It also touches QBar.

@vendethiel
Copy link
Collaborator Author

QBar is too simple for our use case. I need to add more features to it (like being able to specify a PHP function). I want to know, before I do that, because I'm wary of security:

Is PCP available to every single admin on the board? That seems so dangerous... It seems like it should be founder-restricted.

@vendethiel
Copy link
Collaborator Author

I rewrote a good chunk of QBar so that it allows PHP function. I have been able to plug the report buttons into it.

This is what it looks like:

@MWE001
Copy link
Collaborator

MWE001 commented Dec 22, 2018

Items in the ACP is only available according to what permissions you give a User as a Jr Admin on the forum. It is up the Admin to be smart about his or her job and not dish out permissions like Monty Hall on the old Let's Make a Deal (did I just show some age on me?).

And Qbar being "Simple" is for a reason. It was only ever meant to be used for creating menus as far as I can tell. Mountains can be made out of any mole hill if we try hard enough :-) but in the end, it was simply a menu feature and one that worked well at that. It did it's job for the intended purpose at the time. Now it is dated really bad. No sub menus? Oops. Got to have sub Menus. It is pleasing, keeps a board under control (no menu blocks the length of the entire website).

I am curious to see what an Advanced Qbar mod could do though.

@MWE001
Copy link
Collaborator

MWE001 commented Dec 22, 2018

And I figured when you mentioned removing Card Mod that you was in for work. Card Mod is integrated so far I often compared it to CH or PCP. :-) I have never saw the other Mod you mentioned.

@vendethiel
Copy link
Collaborator Author

The « advanced qbar » I made only has one extra feature: PHP can be used to make it dynamic.
Default qbar can only be dynamic with regards to PM, admin, and login/logout.

And while card mod is heavily integrated, it is 1/20 of the size of PCP, which means it’s (around) 20 times simpler to remove it

The reports mod is the screenshot I posted earlier. This is what the interface looks like when someone reports something.

@vendethiel
Copy link
Collaborator Author

Who am I kidding. It’s more like 1/50 of pcp...

@MWE001
Copy link
Collaborator

MWE001 commented Dec 22, 2018

Exactly. That it is. I always hated doing a manual install of it though. it sucked @ss. Not quite as bad as near as bad as PCP or CH but it made me throw a choice word out more than a few times.

@vendethiel
Copy link
Collaborator Author

vendethiel commented Dec 22, 2018

Well this time I'm uninstalling. It's harder though because I don't know how many things were changed in PCP etc.. to make Card Mod work with IM.

Did you look at my screen capture I posted earlier? What do you think about it?

@vendethiel
Copy link
Collaborator Author

vendethiel commented Dec 27, 2018

Actually since Advanced Report Hack has no way to keep track of how many times a user was warned.. I'll do this instead: Keep Yellow Card mod, and integrate it with the Report Hack Mod.

I'll remove the "report" feature of yellow card however. But "blue card" (the report button) will be redirected.

@MWE001
Copy link
Collaborator

MWE001 commented Dec 28, 2018

Sorry Ven I got busy at doctors and such. Yes I did have a look. That screen capture looked pretty decent.

@vendethiel
Copy link
Collaborator Author

Perfect. I will be integrating both with the color username mod, as well as the report mod.

@MWE001
Copy link
Collaborator

MWE001 commented Dec 28, 2018

That sounds good. It looks good thus far.

@vendethiel vendethiel changed the title Remove card mod and implement Advanced Report Hack Add Advanced Report Hack and merge it with Yellow Card Dec 29, 2018
@vendethiel
Copy link
Collaborator Author

An issue I have with the Yellow Card mod is that you have a number of cards, but you don't know who, when, why, or where. I plan to add them, probably in a "card_history" table.

My goal is to have the Report Page from Advanced Report Hack show "this user already has [X] yellow cards "

@vendethiel
Copy link
Collaborator Author

OK, first commit wiht 288e600

@MWE001
Copy link
Collaborator

MWE001 commented Dec 30, 2018

That would actually be pretty sweet. Would it include for what reason? Or just how many they have? I ask that because I have been an admin on many forums before and some mods/admins were power hungry and took it out on members that they "disliked" and cards were handed out that probably should not have been. If it had a mandatory uneditable reason of some type (I'm shooting at the moon here) that an admin could see ..... Now I'm grasping at straws and should be quiet. :-D

@vendethiel
Copy link
Collaborator Author

This is exactly the plan actually. I feel like phpBB in general really dropped the ball on moderation features. It's gotten better but we need to catch up by ourselves.

Any time you want to inflict a card, you need to give a reason.

When you check an user profile, you see the cards & why. Along with a link to all reports by user & about users.

@vendethiel
Copy link
Collaborator Author

vendethiel commented Dec 30, 2018

Maybe even for a moderator, it could list all the inflicted cards.

After this there's not gonna be much code left from the original Yellow Card mod. But it's okay. It's a good template, since it's already integrated in PCP.

@vendethiel
Copy link
Collaborator Author

Annoying part about Advanced Report Hack...
It doesn’t have a « who’s this report about ».
This is not always possible but it should be in most cases (except for general reports).

I’ll have to implement that

@vendethiel
Copy link
Collaborator Author

OK, well.

I just implemented that!
Now the code remembers who was the report about, the "reportee". It also remembers the username in case the user is ever deleted. And you can even filter reports to find all about that specific user!

@vendethiel
Copy link
Collaborator Author

This only needs a fix to work with PCP and is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants