Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override to skip FakedPlayers count? #1

Open
Vel-San opened this issue Apr 18, 2021 · 1 comment
Open

Override to skip FakedPlayers count? #1

Vel-San opened this issue Apr 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@Vel-San
Copy link

Vel-San commented Apr 18, 2021

function TallyVotes(bool bForceMapSwitch)

I haven't taken a deep look into the V3 changes, but I compared V2 with V3 regarding TallyVote (Also vs. Default MapVote). They're taking into consideration NumPlayers, which is counting also FakedPlayers.

Have you tackled this issue in V3? I was thinking maybe we could fix it, but since V3 has several fixes and features over V2 maybe it's better to implement directly here.

From default MapVote's TallyVote, L:681:

// if everyone has voted go ahead and change map
if(bForceMapSwitch || (Level.Game.NumPlayers == PlayersThatVoted && Level.Game.NumPlayers > 0) )

Possible fix

Check for FakedPlus count, then subtract Level.Game.NumPlayers so we get actual Num of Players, or simply make a new ConfigVar in MapVote like iFakedCount=3 that is used only as a reference, so we can easily find the number instead of accessing config of FakedPlus.

@Shtoyan Shtoyan added the enhancement New feature or request label Sep 14, 2021
@Shtoyan
Copy link
Member

Shtoyan commented Sep 14, 2021

[slowpoke mode] Good one, and a reminder for myself to ignore spectator votes as well. [/slowpoke mode]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants