Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose array allocation in add_vector_property() (in population.py) #38

Open
clorton opened this issue Aug 22, 2024 · 1 comment
Open
Assignees

Comments

@clorton
Copy link
Contributor

clorton commented Aug 22, 2024

Probably doesn't have any measurable performance impact, but the current specification of dimensions in array allocation means that the most likely access pattern does not access contiguous locations in memory.

Also, property[tick, :] might be a little more sensible than property[:, tick] from an API perspective.

This would be a breaking change.

@clorton clorton self-assigned this Aug 22, 2024
@krosenfeld-IDM
Copy link
Collaborator

hi @clorton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants