Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Population date of birth initialization should take place upon initialization of birth or mortality functionality, not overall model initialization. #10

Open
KevinMcCarthyAtIDM opened this issue Dec 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@KevinMcCarthyAtIDM
Copy link
Collaborator

Right now, the code flow has date of birth initialization taking place during the model initialization.
At this point in the code flow, the model doesn't know which demographic steps are included in the model components, and the initial date of birth distribution does depend on those. So I'd suggest that we move this over into the initialization of the demographic steps.

The right place to do this would be during initialization of one of the demographics steps. I'm doing constant population demographics, with birth rate = mortality rate, so it makes the most sense for me to not have a mortality step and initialize the "dob" distribution of existing agents when I initialize the births model component.
In a fullest implementation, the initial date of birth distribution is dependent on both the historical birth rates and the historical age-dependent mortality, so needs to know the parameters and dynamics associated with both. In specific implementations where one or both of those might be constant over time, age independent, etc., it could live either on the births or mortality initialization, whichever makes more sense.

@KevinMcCarthyAtIDM KevinMcCarthyAtIDM added the enhancement New feature or request label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant