Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform wait-on-suite does not work #1653

Open
ckirkman-IDM opened this issue Oct 11, 2021 · 4 comments
Open

platform wait-on-suite does not work #1653

ckirkman-IDM opened this issue Oct 11, 2021 · 4 comments
Labels
bug Something isn't working Core Platform support

Comments

@ckirkman-IDM
Copy link
Contributor

It automatically just continues on as its experiments attribute is empty in my case:

idmtools/entities/iplatform.py#wait_till_done_progress:
image

called originally by:
platform.wait_till_done(item=suite)

I believe the fix is to force:
item.platform
... to do child/experiment discovery, as that is disabled by default, I believe for performance.

@ckirkman-IDM ckirkman-IDM added bug Something isn't working Core Platform support labels Oct 11, 2021
@ZDu-IDM
Copy link
Collaborator

ZDu-IDM commented Oct 11, 2021

@ckirkman-IDM
What is the error?
Do you have simple repro code for this issue?
Thanks!

@ckirkman-IDM
Copy link
Contributor Author

The error is' that suite.experiments is an empty list, so that when you call:

platform.wait_till_done(item=suite)

... no waiting occurs (because suite.experiments is empty, implying all done).

This one line fix, an insertion before line 792 in the above image but in the elif block seems to work:

item.experiments = item.platform.get_children(item_id=item.id, item_type=ItemType.SUITE)

@ckirkman-IDM
Copy link
Contributor Author

to repro:
Try commissioning an experiment, get its suite, and do:

platform.wait_till_done(item=suite)

@ckirkman-IDM
Copy link
Contributor Author

(in my case, I was commissioning 6 experiments in 1 suite and wanted to wait for them all in one batch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core Platform support
Projects
None yet
Development

No branches or pull requests

2 participants