Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-Reported Defect: Simulation should check the state of initialization and give a clear message #293

Open
MeWu-IDM opened this issue Aug 4, 2023 · 0 comments
Assignees
Labels
field defect User reported defect

Comments

@MeWu-IDM
Copy link
Collaborator

MeWu-IDM commented Aug 4, 2023

Describe the defect
This issue is when @Nyerere has invalid type in CadreRoles sheet, there was a warning:

pacehrh::InitializeCadreRoles()
Loading cadre roles sheet CadreRoles
Warning message:
Columns with incorrect types in table: OverheadHoursPerWeek

However, this only appears as a warning so user may not be aware of the consequence. later on he is getting an unhandled exception
image

To reproduce
Steps to reproduce the behavior:
specify OverheadHoursPerWeek = NA or something not an integer

Expected behavior
An error handling mechanism for initialization problems before running into the actual calculation (at very least, error should be self-explianary to users)
https://github.com/InstituteforDiseaseModeling/PACE-HRH/blob/main/pacehrh/R/pace_save_cadre_data.R#L21

@MeWu-IDM MeWu-IDM added the field defect User reported defect label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field defect User reported defect
Projects
None yet
Development

No branches or pull requests

2 participants