From d6d78c3f7d229cae81ee465efc4057942e061245 Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Fri, 6 Dec 2024 13:06:05 -0500 Subject: [PATCH 1/3] ci(python-wasm): bump pyodide-actions/install-browser to latest Plus Windows no-sudo patch. --- .github/workflows/python-wasm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/python-wasm.yml b/.github/workflows/python-wasm.yml index 39d64e35f..4fe66359b 100644 --- a/.github/workflows/python-wasm.yml +++ b/.github/workflows/python-wasm.yml @@ -71,7 +71,7 @@ jobs: run: | pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:wasi - - uses: pyodide/pyodide-actions/install-browser@e3edcb8db4f1ec4604e402013f3ae2ee9f114441 + - uses: thewtex/pyodide-actions/install-browser@1e32e8a037a3e99a845dd7ebad6b057a40b7e2c0 if: ${{ matrix.python-minor-version > 10 }} with: runner: selenium From de8f11bfcf3a0f1fd88f4e1bea0410e7e25b4c05 Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Mon, 9 Dec 2024 14:01:15 -0500 Subject: [PATCH 2/3] ci(python-wasm): test pyodide with python > 3.11 --- .github/workflows/python-wasm.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/python-wasm.yml b/.github/workflows/python-wasm.yml index 4fe66359b..860fbbde0 100644 --- a/.github/workflows/python-wasm.yml +++ b/.github/workflows/python-wasm.yml @@ -72,13 +72,13 @@ jobs: pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:wasi - uses: thewtex/pyodide-actions/install-browser@1e32e8a037a3e99a845dd7ebad6b057a40b7e2c0 - if: ${{ matrix.python-minor-version > 10 }} + if: ${{ matrix.python-minor-version > 11 }} with: runner: selenium browser: chrome browser-version: latest - name: Test python on chrome - if: ${{ matrix.python-minor-version > 10 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' || (matrix.package != 'mesh-io' && matrix.package != 'image-io' && matrix.package != 'dicom' && matrix.os != 'macos-14' )}} + if: ${{ matrix.python-minor-version > 11 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' || (matrix.package != 'mesh-io' && matrix.package != 'image-io' && matrix.package != 'dicom' && matrix.os != 'macos-14' )}} run: | pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:emscripten From 81090e0f534d458a35fa569629e9f0b4b38628a8 Mon Sep 17 00:00:00 2001 From: Matt McCormick Date: Mon, 9 Dec 2024 14:57:52 -0500 Subject: [PATCH 3/3] ci(python-wasm): only test pyodide on ubuntu-22.04 This is currently an incompatibility between the selenium and Chrome versions on Windows: ``` ----------------------------- Captured log setup ------------------------------ WARNING selenium.webdriver.common.selenium_manager:selenium_manager.py:138 The chromedriver version (133.0.6888.0) detected in PATH at C:\hostedtoolcache\windows\setup-chrome\chromedriver\1393741\x64\chromedriver.exe might not be compatible with the detected chrome version (131.0.6778.86); currently, chromedriver 131.0.6778.87 is recommended for chrome 131.*, so it is advised to delete the driver in PATH and retry =========================== short test summary info =========================== ERROR test/test_compress_stringify.py::test_example[chrome] - selenium.common.exceptions.SessionNotCreatedException: Message: session not created: This version of ChromeDriver only supports Chrome version 133 Current browser version is 131.0.6778.86 with binary path C:\Program Files\Google\Chrome\Application\chrome.exe Stacktrace: GetHandleVerifier [0x00007FF66A01C635+53269] simdutf::get_active_implementation [0x00007FF669E5D3B7+1684007] (No symbol) [0x00007FF669AFE09B] (No symbol) [0x00007FF669B43DB9] (No symbol) [0x00007FF669B42C00] (No symbol) [0x00007FF669B3D79D] ``` --- .github/workflows/python-wasm.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/python-wasm.yml b/.github/workflows/python-wasm.yml index 860fbbde0..f1bea7929 100644 --- a/.github/workflows/python-wasm.yml +++ b/.github/workflows/python-wasm.yml @@ -72,13 +72,13 @@ jobs: pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:wasi - uses: thewtex/pyodide-actions/install-browser@1e32e8a037a3e99a845dd7ebad6b057a40b7e2c0 - if: ${{ matrix.python-minor-version > 11 }} + if: ${{ matrix.python-minor-version > 11 && matrix.os == 'ubuntu-22.04' }} with: runner: selenium browser: chrome browser-version: latest - name: Test python on chrome - if: ${{ matrix.python-minor-version > 11 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' || (matrix.package != 'mesh-io' && matrix.package != 'image-io' && matrix.package != 'dicom' && matrix.os != 'macos-14' )}} + if: ${{ matrix.python-minor-version > 11 && matrix.package != 'dicom' && matrix.os == 'ubuntu-22.04' }} run: | pnpm run --aggregate-output --filter "@itk-wasm/${{ matrix.package }}-build" test:python:emscripten