Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highlightedCharts is mandatory, but it doesn't have to be #864

Open
Yuwei0021 opened this issue Oct 10, 2024 · 6 comments
Open

highlightedCharts is mandatory, but it doesn't have to be #864

Yuwei0021 opened this issue Oct 10, 2024 · 6 comments

Comments

@Yuwei0021
Copy link

In the configuration of a catalog, if we don't include 'highlightedCharts', for example like this :

catalogs: [  
      {  
        "id": "ide",  
        "name": "Data fabrique",   
        "location": "REPOSITORY_HELM",  
        "status": "PROD",  
        "type": "helm",  
        "multipleServicesMode": "maxNumber",  
        "maxNumberOfVersions": 5,  
      }  
]  

When we land on the catalog page via the 'Catalogue de services' button, nothing is displayed.

@garronej
Copy link
Contributor

Ok thank you for reporting!
I'll fix that

@garronej
Copy link
Contributor

Hey @Yuwei0021, unfortunately, i'm unable to reproduce.

I'll let @fcomte or @olevitt tell me if this is an actual issue.

@olevitt
Copy link
Contributor

olevitt commented Oct 10, 2024

Hi !

I managed to reproduce on first try in a brand New instance, with a single catalog, with no (Key not present) highlightedChart. On both V8 and v9.
Adding `highlightedCharts: [...]" solved the issue

@garronej
Copy link
Contributor

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array...
Can you have a look at what the API sends back?
Maybe it sends an empty string as value of highlightedCharts or something.

@olevitt
Copy link
Contributor

olevitt commented Oct 10, 2024

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

@olevitt
Copy link
Contributor

olevitt commented Oct 11, 2024

Looking at the code I can't figure out what's going on and surely if highlightedCharts I set it to an empty array... Can you have a look at what the API sends back? Maybe it sends an empty string as value of highlightedCharts or something.

I will set you up an env with the bug tomorrow

Could not reproduce today.
I swear I had the issue yesterday with the following configuration on both the latest v8 and latest v9 :

  ingress:
    enabled: true
    hosts:
      - host: <myurl>
    tls:
      - hosts:
          - <myurl>

  api:
    catalogs:
      [
        {
          id: "ide",
          name: "Interactive services",
          location: "https://inseefrlab.github.io/helm-charts-interactive-services",
          status: "PROD",
          type: "helm"
        }
      ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants